linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Sojka <michal.sojka@cvut.cz>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-trace-devel@vger.kernel.org,
	Michal Sojka <michal.sojka@cvut.cz>
Subject: [PATCH 4/4] kernel-shark: Do not use sudo in install_gui.sh + update README
Date: Wed, 17 Mar 2021 17:41:01 +0100	[thread overview]
Message-ID: <20210317164101.30848-5-michal.sojka@cvut.cz> (raw)
In-Reply-To: <20210317164101.30848-1-michal.sojka@cvut.cz>

Using `make install` to install kernelshark can lead to errors
described in the previous commit. Therefore, we instruct users to use
the provided script install_gui.sh. We update the script not to use
sudo, because it's preferable if users give root privileges explicitly
via command line.

Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
---
 README               | 2 +-
 build/install_gui.sh | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README b/README
index a7e66df..f5035f9 100644
--- a/README
+++ b/README
@@ -51,7 +51,7 @@ Building:
     cd kernel-shark/build
     cmake ../
     make
-    sudo make install
+    sudo ./install_gui.sh
 
 2.1 In order to create a Doxygen documentation add -D_DOXYGEN_DOC=1
 as a CMake Command-Line option.
diff --git a/build/install_gui.sh b/build/install_gui.sh
index d262f79..c42f4da 100755
--- a/build/install_gui.sh
+++ b/build/install_gui.sh
@@ -1,9 +1,9 @@
-if sudo cmake -DCOMPONENT=kernelshark -P cmake_install.cmake; then
+if cmake -DCOMPONENT=kernelshark -P cmake_install.cmake; then
     echo "Kernelshark installed correctly"
 else
     exit 1
 fi
 
-if ! sudo cmake -DCOMPONENT=polkit-policy -P cmake_install.cmake; then
+if ! cmake -DCOMPONENT=polkit-policy -P cmake_install.cmake; then
     echo >&2 "Warning: polkit policy not installed"
 fi
-- 
2.30.1


  parent reply	other threads:[~2021-03-17 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 16:40 [PATCH 0/4] kernel-shark: CMake changes Michal Sojka
2021-03-17 16:40 ` [PATCH 1/4] kernel-shark: Allow specifying PKG_CONFIG_DIR on cmake command line Michal Sojka
2021-03-17 16:40 ` [PATCH 2/4] kernel-shark: Allow specifying TT_FONT_FILE " Michal Sojka
2021-03-17 16:41 ` [PATCH 3/4] kernel-shark: Allow installing polkit policy separately Michal Sojka
2021-03-17 16:41 ` Michal Sojka [this message]
2021-03-23 13:45 ` [PATCH 0/4] kernel-shark: CMake changes Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317164101.30848-5-michal.sojka@cvut.cz \
    --to=michal.sojka@cvut.cz \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).