linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtracefs: Prefer using const pointer arguments
Date: Tue, 23 Mar 2021 09:06:47 -0400	[thread overview]
Message-ID: <20210323090647.357b4275@gandalf.local.home> (raw)
In-Reply-To: <c414dd4b-60c3-bdfb-0e23-ee9c307a3518@gmail.com>

On Tue, 23 Mar 2021 14:58:07 +0200
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> I really need to change all "char *" arguments to "const char *". 
> Changing "tracefs_instance *" to "const tracefs_instance *" is more a 
> style preference.

I totally agree on the "char *" to "const char *", as that can make a huge
difference.

I'm not adverse to the "const struct tracefs_instance *" change, I'm just
hesitant due to my years of torment by non flexible APIs ;-)

-- Steve

      reply	other threads:[~2021-03-23 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 14:29 [PATCH] libtracefs: Prefer using const pointer arguments Yordan Karadzhov (VMware)
2021-03-22 15:47 ` Steven Rostedt
2021-03-22 16:59   ` Yordan Karadzhov (VMware)
2021-03-22 22:29     ` Steven Rostedt
2021-03-23 12:58       ` Yordan Karadzhov (VMware)
2021-03-23 13:06         ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323090647.357b4275@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).