From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8F2C433C1 for ; Wed, 24 Mar 2021 22:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CD5261A16 for ; Wed, 24 Mar 2021 22:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234921AbhCXWBR (ORCPT ); Wed, 24 Mar 2021 18:01:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:43586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234833AbhCXWAq (ORCPT ); Wed, 24 Mar 2021 18:00:46 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D987C61A14 for ; Wed, 24 Mar 2021 22:00:45 +0000 (UTC) Date: Wed, 24 Mar 2021 18:00:44 -0400 From: Steven Rostedt To: Linux Trace Devel Subject: [PATCH] trace-cmd: Test for NULL pointer in tracecmd_tsync_free() Message-ID: <20210324180044.748d8b4b@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: "Steven Rostedt (VMware)" If an error happens it is possible that tracecmd_tsync_free() gets called with a NULL pointer, which causes a SIGSEGV crash. Prevent a crash by testing if the tsync passed into tracecmd_tsync_free() is NULL. Signed-off-by: Steven Rostedt (VMware) --- lib/trace-cmd/trace-timesync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c index 8d01c0bc..a4083f51 100644 --- a/lib/trace-cmd/trace-timesync.c +++ b/lib/trace-cmd/trace-timesync.c @@ -381,7 +381,7 @@ void tracecmd_tsync_free(struct tracecmd_time_sync *tsync) struct clock_sync_context *tsync_context; struct tsync_proto *proto; - if (!tsync->context) + if (!tsync || !tsync->context) return; tsync_context = (struct clock_sync_context *)tsync->context; -- 2.25.4