* [PATCH] trace-cmd: Fix double free in tsync_agent_thread()
@ 2021-03-31 21:05 Steven Rostedt
2021-03-31 21:48 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2021-03-31 21:05 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
tracecmd_tsync_free() already frees the tsync, remove the free of it after
that is called.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-timesync.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c
index e860c335..ad73f08f 100644
--- a/lib/trace-cmd/trace-timesync.c
+++ b/lib/trace-cmd/trace-timesync.c
@@ -887,7 +887,6 @@ static void *tsync_agent_thread(void *data)
out:
tracecmd_msg_handle_close(tsync->msg_handle);
tracecmd_tsync_free(tsync);
- free(tsync);
close(sd);
pthread_exit(0);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] trace-cmd: Fix double free in tsync_agent_thread()
2021-03-31 21:05 [PATCH] trace-cmd: Fix double free in tsync_agent_thread() Steven Rostedt
@ 2021-03-31 21:48 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2021-03-31 21:48 UTC (permalink / raw)
To: Linux Trace Devel
On Wed, 31 Mar 2021 17:05:03 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> tracecmd_tsync_free() already frees the tsync, remove the free of it after
> that is called.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> lib/trace-cmd/trace-timesync.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c
> index e860c335..ad73f08f 100644
> --- a/lib/trace-cmd/trace-timesync.c
> +++ b/lib/trace-cmd/trace-timesync.c
> @@ -887,7 +887,6 @@ static void *tsync_agent_thread(void *data)
> out:
> tracecmd_msg_handle_close(tsync->msg_handle);
> tracecmd_tsync_free(tsync);
> - free(tsync);
> close(sd);
>
Debugging this more, this entire ending is wrong. New patch coming.
-- Steve
> pthread_exit(0);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 21:05 [PATCH] trace-cmd: Fix double free in tsync_agent_thread() Steven Rostedt
2021-03-31 21:48 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).