From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Subject: [PATCH 1/3] trace-cmd agent: Clean up tsync_agent_thread() and tsync_host_thread()
Date: Wed, 31 Mar 2021 19:06:11 -0400 [thread overview]
Message-ID: <20210331230728.042865031@goodmis.org> (raw)
In-Reply-To: 20210331230610.035418770@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
There's no reason to assign tsync to NULL nor add a typecast to data, as
void pointers naturally can be converted to any type.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-timesync.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c
index ad73f08f7070..4ed283eb1fb8 100644
--- a/lib/trace-cmd/trace-timesync.c
+++ b/lib/trace-cmd/trace-timesync.c
@@ -697,9 +697,8 @@ static int tsync_with_guest(struct tracecmd_time_sync *tsync)
static void *tsync_host_thread(void *data)
{
- struct tracecmd_time_sync *tsync = NULL;
+ struct tracecmd_time_sync *tsync = data;
- tsync = (struct tracecmd_time_sync *)data;
tsync_with_guest(tsync);
tracecmd_msg_handle_close(tsync->msg_handle);
tsync->msg_handle = NULL;
@@ -865,11 +864,9 @@ int tracecmd_tsync_with_guest_stop(struct tracecmd_time_sync *tsync)
static void *tsync_agent_thread(void *data)
{
- struct tracecmd_time_sync *tsync = NULL;
+ struct tracecmd_time_sync *tsync = data;
int sd;
- tsync = (struct tracecmd_time_sync *)data;
-
while (true) {
sd = accept(tsync->msg_handle->fd, NULL, NULL);
if (sd < 0) {
--
2.30.1
next prev parent reply other threads:[~2021-03-31 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 23:06 [PATCH 0/3] trace-cmd: Fix the memory mangement of trace-cmd agent Steven Rostedt
2021-03-31 23:06 ` Steven Rostedt [this message]
2021-03-31 23:06 ` [PATCH 2/3] trace-cmd: Have tracecmd_tsync_free() free even with no context Steven Rostedt
2021-03-31 23:06 ` [PATCH 3/3] trace-cmd: Do not free tsync from thread Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331230728.042865031@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).