From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, tz.stoyanov@gmail.com
Subject: Re: [PATCH 4/6] libtracefs: Move the "options" code to tracefs-instance.c
Date: Fri, 2 Apr 2021 10:17:56 -0400 [thread overview]
Message-ID: <20210402101756.36879d49@gandalf.local.home> (raw)
In-Reply-To: <20210402131947.346235-5-y.karadz@gmail.com>
On Fri, 2 Apr 2021 16:19:45 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> We would like the instance object to own two bit masks (struct
> tracefs_options_mask) associated with all supported and all enabled
> options. However, the definition of the instance itself is not public,
> hence the code implementing the "options" related APIs has to in the
> same source file as the definition of the instance.
The above is not true. We can keep the code in tracefs-tools.c and make it
"public" for the internal use of the library, but not part of the API. To
do so, you place shared structures and functions in include/tracefs-local.h,
and mark all non static functions with "__hidden" which will keep it from
being used outside the library.
Do you still feel that the moving of this code is needed?
-- Steve
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> src/tracefs-instance.c | 266 +++++++++++++++++++++++++++++++++++++++++
> src/tracefs-tools.c | 266 -----------------------------------------
> 2 files changed, 266 insertions(+), 266 deletions(-)
next prev parent reply other threads:[~2021-04-02 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 13:19 [PATCH 0/6] Refactor the APIs for tracing options Yordan Karadzhov (VMware)
2021-04-02 13:19 ` [PATCH 1/6] libtracefs: Fix issues with tracefs_option_id() Yordan Karadzhov (VMware)
2021-04-02 13:19 ` [PATCH 2/6] libtracefs: Modify the arguments of tracefs_option_is_set() Yordan Karadzhov (VMware)
2021-04-02 13:19 ` [PATCH 3/6] libtracefs: Encapsulate "struct tracefs_options_mask" Yordan Karadzhov (VMware)
2021-04-02 14:13 ` Steven Rostedt
2021-04-02 13:19 ` [PATCH 4/6] libtracefs: Move the "options" code to tracefs-instance.c Yordan Karadzhov (VMware)
2021-04-02 14:17 ` Steven Rostedt [this message]
2021-04-02 14:20 ` Steven Rostedt
2021-04-02 16:01 ` Yordan Karadzhov
2021-04-02 13:19 ` [PATCH 5/6] libtracefs: Option's bit masks to be owned by the instance Yordan Karadzhov (VMware)
2021-04-05 10:50 ` Tzvetomir Stoyanov
2021-04-05 15:01 ` Yordan Karadzhov
2021-04-05 15:10 ` Steven Rostedt
2021-04-05 10:56 ` Tzvetomir Stoyanov
2021-04-05 15:03 ` Yordan Karadzhov
2021-04-02 13:19 ` [PATCH 6/6] libtracefs: Rename tracefs_option_is_set() Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402101756.36879d49@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).