From: Steven Rostedt <rostedt@goodmis.org>
To: sameeruddin shaik <sameeruddin.shaik8@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd: Add CODING_STYLE and CONTRIBUTE documents
Date: Tue, 6 Apr 2021 08:36:20 -0400 [thread overview]
Message-ID: <20210406083620.28b2d9dd@gandalf.local.home> (raw)
In-Reply-To: <326561d9-81de-76a9-1e0d-f98ad23024d5@gmail.com>
On Wed, 7 Apr 2021 06:28:35 +0530
sameeruddin shaik <sameeruddin.shaik8@gmail.com> wrote:
> > +Finally, you can use the git "send-email" functionality:
> > +
> > + git --send-email --from='<your-email> --to='linux-trace-devel@vger.kernel.org' HEAD~1..HEAD
> I think, we should add a line about "checking the patch using the
> checkpatch script, before sending the email", what you say?
I'll add that, although I will say to think of checkpatch as more of a
guide and not a requirement. I find there's a lot of checkpatch fixes
that cause the code to be less readable. But I agree that it is useful for
someone just entering the project.
>
> Another suggestion is,
>
> we should document about, how to apply the mailing list patches, which
> are not yet mainlined. people can search in the internet, but different
> forums will give different approaches.
And I can give different approaches ;-) The approach I gave to you with
patchwork may not be the best either. If I do add something here, it will
to use a new tool called "b4".
For example, you can apply this patch with:
$ b4 am 20210405151959.1d6901b2@gandalf.local.home
Where I used the Message-ID of my email. It also works with series.
Anyway, thanks for the input. This was the reason I included you on this
patch.
-- Steve
prev parent reply other threads:[~2021-04-06 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 19:19 [PATCH] trace-cmd: Add CODING_STYLE and CONTRIBUTE documents Steven Rostedt
2021-04-06 8:18 ` Yordan Karadzhov
2021-04-06 12:39 ` Steven Rostedt
2021-04-06 9:37 ` Tzvetomir Stoyanov
2021-04-06 12:47 ` Steven Rostedt
2021-04-07 0:58 ` sameeruddin shaik
2021-04-06 12:36 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406083620.28b2d9dd@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sameeruddin.shaik8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).