From: Steven Rostedt <rostedt@goodmis.org>
To: <linux-trace-devel@vger.kernel.org>
Cc: Nicolas Sterchele <nicolas@sterchelen.net>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>
Subject: [PATCH v2 2/3] trace-cmd list: Use tracefs to help find events for -e
Date: Thu, 22 Apr 2021 17:18:02 -0400 [thread overview]
Message-ID: <20210422211803.862397-3-rostedt@goodmis.org> (raw)
In-Reply-To: <20210422211803.862397-1-rostedt@goodmis.org>
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
When the user specifies -e and wants to search for events, use the tracefs
helper functions tracefs_event_systems() and tracefs_system_events() to
find the matching events.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
tracecmd/trace-list.c | 135 ++++++++++++++++++++++++++++++++++++++++--
1 file changed, 131 insertions(+), 4 deletions(-)
diff --git a/tracecmd/trace-list.c b/tracecmd/trace-list.c
index c33ce8d9..3e9e2713 100644
--- a/tracecmd/trace-list.c
+++ b/tracecmd/trace-list.c
@@ -106,6 +106,123 @@ static void process_file_re(process_file_func func,
regfree(®);
}
+static void show_event(process_file_func func, const char *system,
+ const char *event, int flags)
+{
+ char *buf;
+ int ret;
+
+ ret = asprintf(&buf, "%s:%s", system, event);
+ if (ret < 0)
+ die("Can not allocate event");
+ func(buf, strlen(buf), flags);
+ free(buf);
+}
+
+static void show_system(process_file_func func, const char *system, int flags)
+{
+ char **events;
+ int e;
+
+ events = tracefs_system_events(NULL, system);
+ if (!events) /* die? */
+ return;
+
+ for (e = 0; events[e]; e++)
+ show_event(func, system, events[e], flags);
+}
+
+static void show_event_systems(process_file_func func, char **systems, int flags)
+{
+ int s;
+
+ for (s = 0; systems[s]; s++)
+ show_system(func, systems[s], flags);
+}
+
+
+static void process_events(process_file_func func, const char *re, int flags)
+{
+ regex_t system_reg;
+ regex_t event_reg;
+ char *str;
+ size_t l = strlen(re);
+ bool just_systems = true;
+ char **systems;
+ char **events;
+ char *system;
+ char *event;
+ int s, e;
+
+ systems = tracefs_event_systems(NULL);
+ if (!systems)
+ return process_file_re(func, "available_events", re, flags);
+
+ if (!re || l == 0) {
+ show_event_systems(func, systems, flags);
+ return;
+ }
+
+ str = strdup(re);
+ if (!str)
+ die("Can not allocate momory for regex");
+
+ system = strtok(str, ":");
+ event = strtok(NULL, "");
+
+ if (regcomp(&system_reg, system, REG_ICASE|REG_NOSUB))
+ die("invalid regex '%s'", system);
+
+ if (event) {
+ if (regcomp(&event_reg, event, REG_ICASE|REG_NOSUB))
+ die("invalid regex '%s'", event);
+ } else {
+ /*
+ * If the regex ends with ":", then event would be null,
+ * but we do not want to match events.
+ */
+ if (re[l-1] != ':')
+ just_systems = false;
+ }
+ free(str);
+
+ for (s = 0; systems[s]; s++) {
+
+ if (regexec(&system_reg, systems[s], 0, NULL, 0) == 0) {
+ if (!event) {
+ show_system(func, systems[s], flags);
+ continue;
+ }
+ events = tracefs_system_events(NULL, systems[s]);
+ if (!events) /* die? */
+ continue;
+ for (e = 0; events[e]; e++) {
+ if (regexec(&event_reg, events[e], 0, NULL, 0) == 0)
+ show_event(func, systems[s], events[e], flags);
+ }
+ tracefs_list_free(events);
+ continue;
+ }
+ if (just_systems)
+ continue;
+
+ events = tracefs_system_events(NULL, systems[s]);
+ if (!events) /* die? */
+ continue;
+
+ for (e = 0; events[e]; e++) {
+ if (regexec(&system_reg, events[e], 0, NULL, 0) == 0)
+ show_event(func, systems[s], events[e], flags);
+ }
+ tracefs_list_free(events);
+ }
+ tracefs_list_free(systems);
+
+ regfree(&system_reg);
+ if (event)
+ regfree(&event_reg);
+}
+
static int show_file_write(char *buf, int len, int flags)
{
return fwrite(buf, 1, len, stdout);
@@ -214,24 +331,34 @@ static int event_format_write(char *fbuf, int len, int flags)
return 0;
}
+static int event_name(char *buf, int len, int flags)
+{
+ printf("%s\n", buf);
+
+ return 0;
+}
static void show_event_filter_re(const char *re)
{
- process_file_re(event_filter_write, "available_events", re, 0);
+ process_events(event_filter_write, re, 0);
}
static void show_event_trigger_re(const char *re)
{
- process_file_re(event_trigger_write, "available_events", re, 0);
+ process_events(event_trigger_write, re, 0);
}
static void show_event_format_re(const char *re, int flags)
{
- process_file_re(event_format_write, "available_events", re, flags);
+ process_events(event_format_write, re, flags);
}
+static void show_event_names_re(const char *re)
+{
+ process_events(event_name, re, 0);
+}
static void show_events(const char *eventre, int flags)
{
@@ -248,7 +375,7 @@ static void show_events(const char *eventre, int flags)
else if (flags & SHOW_EVENT_TRIGGER)
show_event_trigger_re(eventre);
else
- show_file_re("available_events", eventre);
+ show_event_names_re(eventre);
} else
show_file("available_events");
}
--
2.29.2
next prev parent reply other threads:[~2021-04-22 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 21:18 [PATCH v2 0/3] trace-cmd: Add more ways to view options Steven Rostedt
2021-04-22 21:18 ` [PATCH v2 1/3] trace-cmd list: Add --full to show print fmt of an event Steven Rostedt
2021-04-22 21:18 ` Steven Rostedt [this message]
2021-04-22 21:18 ` [PATCH v2 3/3] trace-cmd list: Add ftrace events to listing of events Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422211803.862397-3-rostedt@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=nicolas@sterchelen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).