From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8FCC433ED for ; Thu, 29 Apr 2021 01:20:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23CA86143A for ; Thu, 29 Apr 2021 01:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbhD2BVU convert rfc822-to-8bit (ORCPT ); Wed, 28 Apr 2021 21:21:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:57534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbhD2BVT (ORCPT ); Wed, 28 Apr 2021 21:21:19 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB6826143A; Thu, 29 Apr 2021 01:20:33 +0000 (UTC) Date: Wed, 28 Apr 2021 21:20:32 -0400 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 2/6] trace-cmd library: Add new API to get file version of input handler Message-ID: <20210428212032.589a8d8a@oasis.local.home> In-Reply-To: <20210422071718.483383-3-tz.stoyanov@gmail.com> References: <20210422071718.483383-1-tz.stoyanov@gmail.com> <20210422071718.483383-3-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 22 Apr 2021 10:17:14 +0300 "Tzvetomir Stoyanov (VMware)" wrote: > Added an API to get the version of the trace file, associated with given > input file handler. > tracecmd_get_file_version() > > Signed-off-by: Tzvetomir Stoyanov (VMware) > --- > lib/trace-cmd/include/private/trace-cmd-private.h | 2 ++ > lib/trace-cmd/trace-input.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/lib/trace-cmd/include/private/trace-cmd-private.h b/lib/trace-cmd/include/private/trace-cmd-private.h > index dccd8ae5..fa5b8880 100644 > --- a/lib/trace-cmd/include/private/trace-cmd-private.h > +++ b/lib/trace-cmd/include/private/trace-cmd-private.h > @@ -232,6 +232,8 @@ int tracecmd_set_cursor(struct tracecmd_input *handle, > unsigned long long > tracecmd_get_cursor(struct tracecmd_input *handle, int cpu); > > +unsigned long tracecmd_get_file_version(struct tracecmd_input *handle); > + > int tracecmd_ftrace_overrides(struct tracecmd_input *handle, struct tracecmd_ftrace *finfo); > bool tracecmd_get_use_trace_clock(struct tracecmd_input *handle); > tracecmd_show_data_func > diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c > index a00fa982..b2a03ab8 100644 > --- a/lib/trace-cmd/trace-input.c > +++ b/lib/trace-cmd/trace-input.c > @@ -4034,6 +4034,15 @@ struct tep_handle *tracecmd_get_tep(struct tracecmd_input *handle) > return handle->pevent; > } > > +/** > + * tracecmd_get_file_version - return the trace.dat file version > + * @handle: input handle for the trace.dat file > + */ > +unsigned long tracecmd_get_file_version(struct tracecmd_input *handle) > +{ > + return handle->file_version; > +} This patch doesn't build: trace-input.c: In function ‘tracecmd_get_file_version’: trace-input.c:4033:15: error: ‘struct tracecmd_input’ has no member named ‘file_version’ 4033 | return handle->file_version; | ^~ trace-input.c:4034:1: warning: control reaches end of non-void function [-Wreturn-type] 4034 | } | ^ -- Steve > + > /** > * tracecmd_get_use_trace_clock - return use_trace_clock > * @handle: input handle for the trace.dat file