From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA556C433ED for ; Thu, 29 Apr 2021 12:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7498261423 for ; Thu, 29 Apr 2021 12:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234863AbhD2M4a convert rfc822-to-8bit (ORCPT ); Thu, 29 Apr 2021 08:56:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:59520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234525AbhD2M4a (ORCPT ); Thu, 29 Apr 2021 08:56:30 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0287613FF; Thu, 29 Apr 2021 12:55:42 +0000 (UTC) Date: Thu, 29 Apr 2021 08:55:41 -0400 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: Linux Trace Devel Subject: Re: [PATCH 6/6] trace-cmd record: Add new parameter --file-version Message-ID: <20210429085541.323a0b21@gandalf.local.home> In-Reply-To: References: <20210422071718.483383-1-tz.stoyanov@gmail.com> <20210422071718.483383-7-tz.stoyanov@gmail.com> <20210428212618.41262613@oasis.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 29 Apr 2021 06:34:14 +0300 Tzvetomir Stoyanov wrote: > On Thu, Apr 29, 2021 at 4:26 AM Steven Rostedt wrote: > > > > On Thu, 22 Apr 2021 10:17:18 +0300 > > "Tzvetomir Stoyanov (VMware)" wrote: > > > > > Added a new optional parameter to "trace-cmd record", can be used to > > > select the desired file version of the trace output file. > > > > > > Signed-off-by: Tzvetomir Stoyanov (VMware) > > > > Even with this last patch, I still get: > > > > trace-input.c: In function ‘tracecmd_get_file_version’: > > trace-input.c:4033:15: error: ‘struct tracecmd_input’ has no member named ‘file_version’ > > 4033 | return handle->file_version; > > | ^~ > > trace-input.c:4034:1: warning: control reaches end of non-void function [-Wreturn-type] > > 4034 | } > > > > So you must have added a change without somehow committing it :-/ > > The confusion is from another dependency - the "[PATCH 0/6] Bump trace > file version" patchset depends on "[PATCH v2] trace-cmd: Check if file > version is supported". I wrote that in the cover letter, but maybe Ah, I didn't read the cover letter, and just pulled the patches directly from patchwork. I missed the v2 in patch work as well. My fault, I should have read the cover letter, but knowing what it was from conversations I didn't look at it. And because I didn't see the patch that it depended on in patchwork (it was hidden between Yordan's and my patch) I didn't think it would have any dependencies, which is where I was confused. > that patch should be part of the set as well. I'll send the v2 of the > "Bump trace file version" with this additional patch. Strange, I do > not see that patchset in patchwork, only in the mailing list. > Yeah, I marked the series as "change requested" which hides it from the normal view. -- Steve