From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] trace-cmd record: Add new parameter --file-version
Date: Thu, 29 Apr 2021 09:54:10 -0400 [thread overview]
Message-ID: <20210429095410.48963b4e@gandalf.local.home> (raw)
In-Reply-To: <20210429040119.843617-8-tz.stoyanov@gmail.com>
On Thu, 29 Apr 2021 07:01:19 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> Added a new optional parameter to "trace-cmd record", can be used to
> select the desired file version of the trace output file.
I'm not sure record should be where a version is specified. Let the user
decide if they can disable a feature that requires a higher version of the
file. That is, if the user does "--no-compression" or whatever we call it,
then it will just save as version 6.
Now what we should do, is to have a conversion command.
trace-cmd convert <version> <input.dat> <output.dat>
$ trace-cmd convert 6 trace-7.dat trace-6.dat
We'll just have to document (probably in the convert man page) what
features are added to which version, and how to set up the record to have
it go to a lower version).
-- Steve
next prev parent reply other threads:[~2021-04-29 13:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 4:01 [PATCH v2 0/7] Bump trace file version Tzvetomir Stoyanov (VMware)
2021-04-29 4:01 ` [PATCH v2 1/7] trace-cmd library: Remove unused private APIs for creating trace files Tzvetomir Stoyanov (VMware)
2021-04-29 4:01 ` [PATCH v2 2/7] trace-cmd: Check if file version is supported Tzvetomir Stoyanov (VMware)
2021-04-29 4:01 ` [PATCH v2 3/7] trace-cmd library: Bump the trace file version to 7 Tzvetomir Stoyanov (VMware)
2021-04-29 4:01 ` [PATCH v2 4/7] trace-cmd library: Add new API to get file version of input handler Tzvetomir Stoyanov (VMware)
2021-04-29 4:01 ` [PATCH v2 5/7] trace-cmd library: Select the file version when writing trace file Tzvetomir Stoyanov (VMware)
2021-04-29 13:42 ` Steven Rostedt
2021-04-29 4:01 ` [PATCH v2 6/7] trace-cmd library: Extend the create file APIs to support different file version Tzvetomir Stoyanov (VMware)
2021-04-29 13:50 ` Steven Rostedt
2021-04-29 4:01 ` [PATCH v2 7/7] trace-cmd record: Add new parameter --file-version Tzvetomir Stoyanov (VMware)
2021-04-29 13:54 ` Steven Rostedt [this message]
2021-05-10 6:22 ` [PATCH v2 0/7] Bump trace file version Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429095410.48963b4e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).