linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/4] libtraceevent: Add logs with severity info
Date: Tue, 4 May 2021 16:34:16 -0400	[thread overview]
Message-ID: <20210504163416.066b1d9a@gandalf.local.home> (raw)
In-Reply-To: <20210504160008.3f6f2e01@gandalf.local.home>

On Tue, 4 May 2021 16:00:08 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > Renamed existing pr_stat() internal function to tep_info() and limit it  
> 
> Unfortunately they are also not internal functions :-(
> 
> > to print only when the log level is TEP_LOG_INFO. Removed duplicated and
> > unused functions:
> >  vpr_stat()
> >  __pr_stat()
> >  __vpr_stat()  
> 
> trace-record.c: In function ‘expand_event_files’:
> trace-record.c:2971:3: warning: implicit declaration of function ‘pr_stat’; did you mean ‘lstat’? [-Wimplicit-function-declaration]
>  2971 |   pr_stat("%s\n", path);
>       |   ^~~~~~~
>       |   lstat
> 
> 
> ctracecmd_wrap.c: In function ‘pr_stat’:
> ctracecmd_wrap.c:2779:2: warning: implicit declaration of function ‘__vpr_stat’; did you mean ‘pr_stat’? [-Wimplicit-function-declaration]
>  2779 |  __vpr_stat(fmt, ap);
>       |  ^~~~~~~~~~
>       |  pr_stat

So I added another patch to bring these back for backward compatibility.
Feel free to remove them in this series, and I'll just add that patch at
the end:

  https://lore.kernel.org/linux-trace-devel/20210504163156.2bfdd63d@gandalf.local.home/

But as I still have issues with this patch series and will wait for your
reply before applying anything.

Thanks,

-- Steve

  reply	other threads:[~2021-05-04 20:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  7:29 [PATCH 0/4] Add severity to library logs Tzvetomir Stoyanov (VMware)
2021-04-28  7:29 ` [PATCH 1/4] libtraceevent: Add log levels Tzvetomir Stoyanov (VMware)
2021-04-28  7:29 ` [PATCH 2/4] libtraceevent: Add logs with severity info Tzvetomir Stoyanov (VMware)
2021-05-04 20:00   ` Steven Rostedt
2021-05-04 20:34     ` Steven Rostedt [this message]
2021-05-04 20:24   ` Steven Rostedt
2021-05-05  4:45     ` Tzvetomir Stoyanov
2021-05-05  9:55       ` Steven Rostedt
2021-04-28  7:30 ` [PATCH 3/4] libtraceevent: Rename tep_vwarning() to tep_vprint() Tzvetomir Stoyanov (VMware)
2021-05-04 20:22   ` Steven Rostedt
2021-04-28  7:30 ` [PATCH 4/4] libtraceevent: Document new log functionality Tzvetomir Stoyanov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210504163416.066b1d9a@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).