From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFD0C433ED for ; Mon, 10 May 2021 21:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E574B613DF for ; Mon, 10 May 2021 21:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231213AbhEJVDm convert rfc822-to-8bit (ORCPT ); Mon, 10 May 2021 17:03:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:45812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230289AbhEJVDm (ORCPT ); Mon, 10 May 2021 17:03:42 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80CA661554; Mon, 10 May 2021 21:02:36 +0000 (UTC) Date: Mon, 10 May 2021 17:02:34 -0400 From: Steven Rostedt To: Yordan Karadzhov Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 3/9] kernel-shark: Fix KS_DEFINE_PLUGIN_CONTEXT macro Message-ID: <20210510170234.41c8136a@gandalf.local.home> In-Reply-To: <96e06290-f5e8-34ac-1b3e-db8559bffd1f@gmail.com> References: <20210428134730.187533-1-y.karadz@gmail.com> <20210428134730.187533-4-y.karadz@gmail.com> <20210506141151.2f31f263@gandalf.local.home> <6c352db2-1f2a-4442-1832-1810d4d6a1a2@gmail.com> <20210510142537.2628c47b@gandalf.local.home> <20210510152349.3de97b82@gandalf.local.home> <96e06290-f5e8-34ac-1b3e-db8559bffd1f@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 10 May 2021 23:34:50 +0300 Yordan Karadzhov wrote: > On 10.05.21 г. 22:23, Steven Rostedt wrote: > > Obviously, I'm missing something to connect the > > dots. > > And I have to admit that the commit message is misleading. :-) Yes, please rewrite the commit message to explain exactly what that patch is doing. That's what threw me for the loop. I read it, and was basing all my review on what the commit message said, and not what I saw in the patch. -- Steve