linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] libtraceevent: Rename tep_vwarning() to tep_vprint()
Date: Wed, 12 May 2021 21:52:44 -0400	[thread overview]
Message-ID: <20210512215244.2b95404c@oasis.local.home> (raw)
In-Reply-To: <20210507095022.1079364-4-tz.stoyanov@gmail.com>

On Fri,  7 May 2021 12:50:21 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:

> diff --git a/src/event-utils.h b/src/event-utils.h
> index 1951557..0617a28 100644
> --- a/src/event-utils.h
> +++ b/src/event-utils.h
> @@ -9,10 +9,11 @@
>  #include <ctype.h>
>  #include <stdarg.h>
>  
> +void tep_warning(const char *fmt, ...);
>  void tep_info(const char *fmt, ...);
>  /* Can be overridden */
> -void tep_warning(const char *fmt, ...);
> -int tep_vwarning(const char *name, const char *fmt, va_list ap);
> +int tep_vprint(const char *name, enum tep_loglevel level,
> +	       bool print_err, const char *fmt, va_list ap);
>  
>  #define min(x, y) ({				\
>  	typeof(x) _min1 = (x);			\

I have the following build error on trace-cmd:

In file included from trace-util.c:23:
/usr/local/include/traceevent/event-utils.h:16:9: error: unknown type name ‘bool’
   16 |         bool print_err, const char *fmt, va_list ap);
      |         ^~~~

Needs to include <stdbool.h> in event-utils.h, can not rely that this
would exist in the use cases.

I'll add it to this patch, unless I find other issues for a v3.

-- Steve

  reply	other threads:[~2021-05-13  1:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07  9:50 [PATCH v2 0/4] Add severity to library logs Tzvetomir Stoyanov (VMware)
2021-05-07  9:50 ` [PATCH v2 1/4] libtraceevent: Add log levels Tzvetomir Stoyanov (VMware)
2021-05-07  9:50 ` [PATCH v2 2/4] libtraceevent: Add logs with severity info Tzvetomir Stoyanov (VMware)
2021-05-07  9:50 ` [PATCH v2 3/4] libtraceevent: Rename tep_vwarning() to tep_vprint() Tzvetomir Stoyanov (VMware)
2021-05-13  1:52   ` Steven Rostedt [this message]
2021-05-07  9:50 ` [PATCH v2 4/4] libtraceevent: Document new log functionality Tzvetomir Stoyanov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512215244.2b95404c@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).