From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] trace-cmd library: Add tracecmd_info() log function
Date: Thu, 13 May 2021 17:22:06 -0400 [thread overview]
Message-ID: <20210513172206.3f3f577f@gandalf.local.home> (raw)
In-Reply-To: <20210507095333.1080910-3-tz.stoyanov@gmail.com>
On Fri, 7 May 2021 12:53:27 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> --- a/tracecmd/trace-record.c
> +++ b/tracecmd/trace-record.c
> @@ -2934,6 +2934,20 @@ static void test_event(struct event_list *event, const char *path,
>
> *save = event;
> }
> +static void pr_stat(const char *fmt, ...)
> +{
> + va_list ap;
> +
> + if (!show_status)
> + return;
> +
> + va_start(ap, fmt);
> + vprintf(fmt, ap);
> + va_end(ap);
> +
> + printf("\n");
> +}
> +
>
Since we need to keep the library pr_stat() for backward compatibility, I
rename this to "print_event()" as that's what it was doing locally anyway.
Otherwise it conflicted with the old pr_stat() that I added back to
libtraceevent.
-- Steve
next prev parent reply other threads:[~2021-05-13 21:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:53 [PATCH v2 0/8] Changes to trace-cmd logs Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 1/8] trace-cmd library: Use tep_vprint() for logs Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 2/8] trace-cmd library: Add tracecmd_info() log function Tzvetomir Stoyanov (VMware)
2021-05-13 21:22 ` Steven Rostedt [this message]
2021-05-07 9:53 ` [PATCH v2 3/8] trace-cmd library: Add log levels Tzvetomir Stoyanov (VMware)
2021-05-13 21:23 ` Steven Rostedt
2021-05-14 2:51 ` Tzvetomir Stoyanov
2021-05-14 3:19 ` Steven Rostedt
2021-05-07 9:53 ` [PATCH v2 4/8] trace-cmd library: Document the API for " Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 5/8] trace-cmd library: Renamed tracecmd_fatal() to tracecmd_critical() Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 6/8] trace-cmd library: Set debug log level in debug mode Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 7/8] trace-cmd report: Set the log level with -V and -q options Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 8/8] trace-cmd: Add new function to set log level Tzvetomir Stoyanov (VMware)
2021-05-13 21:36 ` Steven Rostedt
2021-05-14 2:53 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513172206.3f3f577f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).