From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH] libtraceevent: Better warning print-out
Date: Fri, 14 May 2021 15:28:25 +0300 [thread overview]
Message-ID: <20210514122825.162203-1-y.karadz@gmail.com> (raw)
I see no new line when the messages are printed from KernelShark.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/trace-seq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/trace-seq.c b/src/trace-seq.c
index 8d5ecd2..6aee07a 100644
--- a/src/trace-seq.c
+++ b/src/trace-seq.c
@@ -22,7 +22,7 @@
#define TRACE_SEQ_CHECK(s) \
do { \
if (WARN_ONCE((s)->buffer == TRACE_SEQ_POISON, \
- "Usage of trace_seq after it was destroyed")) \
+ "Usage of trace_seq after it was destroyed\n")) \
(s)->state = TRACE_SEQ__BUFFER_POISONED; \
} while (0)
@@ -85,7 +85,7 @@ static void expand_buffer(struct trace_seq *s)
char *buf;
buf = realloc(s->buffer, s->buffer_size + TRACE_SEQ_BUF_SIZE);
- if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory")) {
+ if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory\n")) {
s->state = TRACE_SEQ__MEM_ALLOC_FAILED;
return;
}
--
2.27.0
next reply other threads:[~2021-05-14 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 12:28 Yordan Karadzhov (VMware) [this message]
2021-05-14 13:18 ` [PATCH] libtraceevent: Better warning print-out Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514122825.162203-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).