From: Steven Rostedt <rostedt@goodmis.org> To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 0/7] Final fixes before KS 2.0 Date: Fri, 14 May 2021 13:45:34 -0400 [thread overview] Message-ID: <20210514134534.7ed08f3b@gandalf.local.home> (raw) In-Reply-To: <20210514121826.161749-1-y.karadz@gmail.com> On Fri, 14 May 2021 15:18:19 +0300 "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > Yordan Karadzhov (VMware) (7): > kernel-shark: Preserve markers when appending data > kernel-shark: Preserve open graphs when appending data > kernel-shark: Clear before loading new session > kernel-shark: Better handling of plugins when appending data file > kernel-shark: Do draw the combo point of the mark > kernel-shark: Check if "trace_seq" was destroyed before using it Besides the above patch, the rest look good. Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve > kernel-shark: Quiet the warning printing from libtraceevent > > src/KsDualMarker.hpp | 6 ++++++ > src/KsGLWidget.cpp | 40 ++++++++++++++++++++++++++-------------- > src/KsGLWidget.hpp | 4 +++- > src/KsMainWindow.cpp | 31 ++++++++++++++++++++++++++----- > src/KsPlotTools.cpp | 3 +++ > src/KsSession.cpp | 1 + > src/KsTraceGraph.cpp | 10 +++++++--- > src/KsTraceGraph.hpp | 2 +- > src/KsUtils.cpp | 4 ++-- > src/libkshark-tepdata.c | 16 +++++++++++++++- > 10 files changed, 90 insertions(+), 27 deletions(-) >
next prev parent reply other threads:[~2021-05-14 17:45 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-14 12:18 Yordan Karadzhov (VMware) 2021-05-14 12:18 ` [PATCH 1/7] kernel-shark: Preserve markers when appending data Yordan Karadzhov (VMware) 2021-05-14 12:18 ` [PATCH 2/7] kernel-shark: Preserve open graphs " Yordan Karadzhov (VMware) 2021-05-14 12:18 ` [PATCH 3/7] kernel-shark: Clear before loading new session Yordan Karadzhov (VMware) 2021-05-14 12:18 ` [PATCH 4/7] kernel-shark: Better handling of plugins when appending data file Yordan Karadzhov (VMware) 2021-05-14 12:18 ` [PATCH 5/7] kernel-shark: Do draw the combo point of the mark Yordan Karadzhov (VMware) 2021-05-14 12:18 ` [PATCH 6/7] kernel-shark: Check if "trace_seq" was destroyed before using it Yordan Karadzhov (VMware) 2021-05-14 13:31 ` Steven Rostedt 2021-05-14 13:45 ` Yordan Karadzhov 2021-05-14 13:57 ` Steven Rostedt 2021-05-14 14:01 ` Yordan Karadzhov 2021-05-14 12:18 ` [PATCH 7/7] kernel-shark: Quiet the warning printing from libtraceevent Yordan Karadzhov (VMware) 2021-05-14 13:33 ` Steven Rostedt 2021-05-14 17:45 ` Steven Rostedt [this message] 2021-05-14 18:01 ` [PATCH 0/7] Final fixes before KS 2.0 Steven Rostedt 2021-05-17 10:22 ` Yordan Karadzhov 2021-05-17 12:54 ` Steven Rostedt 2021-05-17 13:04 ` Yordan Karadzhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210514134534.7ed08f3b@gandalf.local.home \ --to=rostedt@goodmis.org \ --cc=linux-trace-devel@vger.kernel.org \ --cc=y.karadz@gmail.com \ --subject='Re: [PATCH 0/7] Final fixes before KS 2.0' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).