From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF520C433ED for ; Fri, 14 May 2021 17:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC9A66144C for ; Fri, 14 May 2021 17:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230213AbhENRqt (ORCPT ); Fri, 14 May 2021 13:46:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:46952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhENRqt (ORCPT ); Fri, 14 May 2021 13:46:49 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71492613EC; Fri, 14 May 2021 17:45:37 +0000 (UTC) Date: Fri, 14 May 2021 13:45:34 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 0/7] Final fixes before KS 2.0 Message-ID: <20210514134534.7ed08f3b@gandalf.local.home> In-Reply-To: <20210514121826.161749-1-y.karadz@gmail.com> References: <20210514121826.161749-1-y.karadz@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, 14 May 2021 15:18:19 +0300 "Yordan Karadzhov (VMware)" wrote: > Yordan Karadzhov (VMware) (7): > kernel-shark: Preserve markers when appending data > kernel-shark: Preserve open graphs when appending data > kernel-shark: Clear before loading new session > kernel-shark: Better handling of plugins when appending data file > kernel-shark: Do draw the combo point of the mark > kernel-shark: Check if "trace_seq" was destroyed before using it Besides the above patch, the rest look good. Reviewed-by: Steven Rostedt (VMware) -- Steve > kernel-shark: Quiet the warning printing from libtraceevent > > src/KsDualMarker.hpp | 6 ++++++ > src/KsGLWidget.cpp | 40 ++++++++++++++++++++++++++-------------- > src/KsGLWidget.hpp | 4 +++- > src/KsMainWindow.cpp | 31 ++++++++++++++++++++++++++----- > src/KsPlotTools.cpp | 3 +++ > src/KsSession.cpp | 1 + > src/KsTraceGraph.cpp | 10 +++++++--- > src/KsTraceGraph.hpp | 2 +- > src/KsUtils.cpp | 4 ++-- > src/libkshark-tepdata.c | 16 +++++++++++++++- > 10 files changed, 90 insertions(+), 27 deletions(-) >