From: Steven Rostedt <rostedt@goodmis.org>
To: sameeruddin shaik <sameeross1994@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtracefs: Add support for setting tracers
Date: Mon, 17 May 2021 11:21:55 -0400 [thread overview]
Message-ID: <20210517112155.1ee38a59@gandalf.local.home> (raw)
In-Reply-To: <CAN_HWU=M-4zpL0eat2AWAPDsgxBjLJptaicNgXQ=rgWhNhjNWQ@mail.gmail.com>
On Tue, 18 May 2021 20:48:35 +0530
sameeruddin shaik <sameeross1994@gmail.com> wrote:
> > BTW, when a reviewer of your code gives a code example of a better
> > implementation, you should express that in your change log. I usually use:
> >
> > Suggested-by: ...
> >
> > So you should have:
> >
> > Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> >
> > as the above is pretty much exact copy of the code snippet I posted.
> okay steve,
> since i don't know, about this suggested-by, i haven't included. otherwise
> i could have done.
No problem. I'm just educating you ;-)
-- Steve
next prev parent reply other threads:[~2021-05-17 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 9:24 [PATCH] libtracefs: Add support for setting tracers Sameeruddin shaik
2021-05-17 13:05 ` Steven Rostedt
2021-05-18 15:18 ` sameeruddin shaik
2021-05-17 15:21 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-18 15:26 Sameeruddin shaik
2021-05-17 15:32 ` Steven Rostedt
2021-05-16 14:59 Sameeruddin shaik
2021-05-15 16:40 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517112155.1ee38a59@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sameeross1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).