From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 6/6] trace-cmd: Add new function to set log level
Date: Mon, 17 May 2021 16:40:05 +0300 [thread overview]
Message-ID: <20210517134005.611251-7-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210517134005.611251-1-tz.stoyanov@gmail.com>
Introduce a new trace-cmd internal function to set the application log
level.
trace_set_verbose()
The log level can be set using string with log id or log name.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
tracecmd/include/trace-local.h | 2 ++
tracecmd/trace-cmd.c | 40 ++++++++++++++++++++++++++++++++++
2 files changed, 42 insertions(+)
diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h
index 4c5669c9..e9a0aea8 100644
--- a/tracecmd/include/trace-local.h
+++ b/tracecmd/include/trace-local.h
@@ -39,6 +39,8 @@ void usage(char **argv);
extern int silence_warnings;
extern int show_status;
+int trace_set_verbose(char *level);
+
struct pid_record_data {
int pid;
int brass[2];
diff --git a/tracecmd/trace-cmd.c b/tracecmd/trace-cmd.c
index 60cd3ea1..00cdaa37 100644
--- a/tracecmd/trace-cmd.c
+++ b/tracecmd/trace-cmd.c
@@ -45,6 +45,46 @@ void *malloc_or_die(unsigned int size)
return data;
}
+static struct trace_log_severity {
+ int id;
+ const char *name;
+} log_severity[] = {
+ { .id = TEP_LOG_NONE, .name = "none" },
+ { .id = TEP_LOG_CRITICAL, .name = "crit" },
+ { .id = TEP_LOG_ERROR, .name = "err" },
+ { .id = TEP_LOG_WARNING, .name = "warn" },
+ { .id = TEP_LOG_INFO, .name = "info" },
+ { .id = TEP_LOG_DEBUG, .name = "debug" },
+ { .id = TEP_LOG_ALL, .name = "all" },
+};
+
+int trace_set_verbose(char *level)
+{
+ int id;
+
+ if (!level)
+ return -1;
+
+ if (isdigit(level[0])) {
+ id = atoi(level);
+ if (id >= TEP_LOG_NONE && id <= TEP_LOG_ALL) {
+ tracecmd_set_loglevel(id);
+ return 0;
+ }
+ } else {
+ int size = ARRAY_SIZE(log_severity);
+ int i;
+
+ for (i = 0; i < size; i++) {
+ if (!strncmp(level, log_severity[i].name, strlen(log_severity[i].name))) {
+ tracecmd_set_loglevel(log_severity[i].id);
+ return 0;
+ }
+ }
+ }
+
+ return -1;
+}
/**
* struct command
--
2.31.1
prev parent reply other threads:[~2021-05-17 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 13:39 [PATCH v2 0/6] Changes to trace-cmd logs Tzvetomir Stoyanov (VMware)
2021-05-17 13:40 ` [PATCH v2 1/6] trace-cmd library: Add log levels Tzvetomir Stoyanov (VMware)
2021-05-17 13:40 ` [PATCH v2 2/6] trace-cmd library: Document the API for " Tzvetomir Stoyanov (VMware)
2021-05-17 13:40 ` [PATCH v2 3/6] trace-cmd library: Renamed tracecmd_fatal() to tracecmd_critical() Tzvetomir Stoyanov (VMware)
2021-05-17 13:40 ` [PATCH v2 4/6] trace-cmd library: Set debug log level in debug mode Tzvetomir Stoyanov (VMware)
2021-05-17 13:40 ` [PATCH v2 5/6] trace-cmd report: Set the log level with -V and -q options Tzvetomir Stoyanov (VMware)
2021-05-17 13:40 ` Tzvetomir Stoyanov (VMware) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517134005.611251-7-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).