From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> To: linux-trace-devel@vger.kernel.org Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> Subject: [PATCH v2 6/7] kernel-shark: Fix the checking if "trace_seq" was destroyed Date: Mon, 17 May 2021 17:21:39 +0300 [thread overview] Message-ID: <20210517142140.286153-7-y.karadz@gmail.com> (raw) In-Reply-To: <20210517142140.286153-1-y.karadz@gmail.com> When closing a "tep" data stream we destroy the "trace_seq" object. However, trace_seq_destroy() sets the buffer to "TRACE_SEQ_POISON" which is different from NULL. Because TRACE_SEQ_POISON is an internal definition of libtraceevent, we have to set the buffer to NULL in order to indicate that it was destroyed. Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> --- src/libkshark-tepdata.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libkshark-tepdata.c b/src/libkshark-tepdata.c index bc5babb..acc554b 100644 --- a/src/libkshark-tepdata.c +++ b/src/libkshark-tepdata.c @@ -1615,8 +1615,10 @@ int kshark_tep_close_interface(struct kshark_data_stream *stream) if (!tep_handle) return -EFAULT; - if (seq.buffer) + if (seq.buffer) { trace_seq_destroy(&seq); + seq.buffer = NULL; + } if (tep_handle->advanced_event_filter) { tep_filter_reset(tep_handle->advanced_event_filter); -- 2.27.0
next prev parent reply other threads:[~2021-05-17 14:59 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-17 14:21 [PATCH v2 0/7] Final fixes before KS 2.0 Yordan Karadzhov (VMware) 2021-05-17 14:21 ` [PATCH v2 1/7] kernel-shark: Preserve markers when appending data Yordan Karadzhov (VMware) 2021-05-17 14:21 ` [PATCH v2 2/7] kernel-shark: Preserve open graphs " Yordan Karadzhov (VMware) 2021-05-17 14:21 ` [PATCH v2 3/7] kernel-shark: Clear before loading new session Yordan Karadzhov (VMware) 2021-05-17 14:21 ` [PATCH v2 4/7] kernel-shark: Better handling of plugins when appending data file Yordan Karadzhov (VMware) 2021-05-17 14:21 ` [PATCH v2 5/7] kernel-shark: Do draw the combo point of the mark Yordan Karadzhov (VMware) 2021-05-17 14:21 ` Yordan Karadzhov (VMware) [this message] 2021-05-17 14:21 ` [PATCH v2 7/7] kernel-shark: No slash at the end of KS_PLUGIN_INSTALL_PREFIX Yordan Karadzhov (VMware) 2021-05-17 23:21 ` [PATCH v2 0/7] Final fixes before KS 2.0 Steven Rostedt 2021-05-17 23:28 ` Steven Rostedt 2021-05-18 7:30 ` Yordan Karadzhov 2021-05-18 12:46 ` Steven Rostedt 2021-05-18 12:58 ` Yordan Karadzhov 2021-05-18 13:44 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210517142140.286153-7-y.karadz@gmail.com \ --to=y.karadz@gmail.com \ --cc=linux-trace-devel@vger.kernel.org \ --subject='Re: [PATCH v2 6/7] kernel-shark: Fix the checking if "trace_seq" was destroyed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).