From: Steven Rostedt <firstname.lastname@example.org> To: Ian Rogers <email@example.com> Cc: Linux Trace Devel <firstname.lastname@example.org>, Tzvetomir Stoyanov <email@example.com>, Claire Jensen <firstname.lastname@example.org> Subject: Re: [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes. Date: Mon, 14 Jun 2021 14:43:26 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAP-5=fX00qHJmNeEpPCaCj5tqUkjbMc_Lk18o6Dv_ux6ESvSHw@mail.gmail.com> On Mon, 14 Jun 2021 09:14:08 -0700 Ian Rogers <firstname.lastname@example.org> wrote: > On Sun, Jun 13, 2021 at 4:29 PM Steven Rostedt <email@example.com> wrote: > > > > On Sun, 13 Jun 2021 14:31:42 -0700 > > Ian Rogers <firstname.lastname@example.org> wrote: > > > > > > > Would it be more conventional in this situation to use quotes within > > > the library and angles outside? This change is within the library and > > > not with code trying to link against it. > > > > Does it matter? If not, what's the purpose of changing it? > > Sorry for not having this in the body, in the cover message I added to > Claire's email with: > > > Some build systems are picky about angled vs quotes, fix this minor issue. > > The problem is with certain build system, we use bazel at Google, > where iquote is used for includes within the library, and other > flavors outside the library. There's a similar conversation here: > https://groups.google.com/g/bazel-discuss/c/6MNuZ5bKoa8?pli=1 > > the failure you see when building is: > > In file included from src/event-parse.c:27: > src/event-utils.h:13:10: error: 'event-parse.h' file not found with > <angled> include; use "quotes" instead > #include <event-parse.h> > ^~~~~~~~~~~~~~~ > "event-parse.h" > > Arguably -iquote is more correct within the library build, hence bazel > using it. The libtraceevent Makefile is using -I, hence this not being > a problem for others. We prefer not to carry internal patches, hence > wanting to send this upstream. OK, context is very important :-) With the above explanation, it makes sense, and I'm OK with taking it. Please resend with the above in the commit log. Thanks! -- Steve
next prev parent reply other threads:[~2021-06-14 18:43 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-12 1:44 [PATCH 0/2] Build and fuzzing related fixes Ian Rogers 2021-06-12 1:45 ` [PATCH 1/2] libtraceevent: Add eof checks Ian Rogers 2021-06-13 23:30 ` Steven Rostedt [not found] ` <CAFPGG2iQK8XMv6Z1-KurgjOnYuk=m=uWNWJXj6OEb_SBQkokZA@mail.gmail.com> 2021-06-17 19:01 ` Steven Rostedt 2021-06-12 1:45 ` [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes Ian Rogers 2021-06-12 23:00 ` Steven Rostedt 2021-06-13 21:31 ` Ian Rogers 2021-06-13 23:29 ` Steven Rostedt 2021-06-14 16:14 ` Ian Rogers 2021-06-14 18:43 ` Steven Rostedt [this message] 2021-06-17 19:43 [PATCH 1/2] libtraceevent: Add eof checks Claire Jensen 2021-06-17 19:43 ` [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes Claire Jensen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).