From: Steven Rostedt <rostedt@goodmis.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd split: Copy trace_clock from input handler to output handler
Date: Tue, 22 Jun 2021 17:38:43 -0400 [thread overview]
Message-ID: <20210622173843.496b0ca3@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2106222322590.80759@hadrien>
On Tue, 22 Jun 2021 23:25:23 +0200 (CEST)
Julia Lawall <julia.lawall@inria.fr> wrote:
> > Add a new function to retrieve the trace_clock from the input handle, to
> > be used to pass it to the output handle before appending the CPU data.
>
> Just to confirm, is it still possible to run trace-cmd split without being
> root?
Yes, it was a bug that you couldn't read it as non-root. And it shouldn't be
reading the local trace_clock anyway, even if you are root.
1) because it could be splitting a trace.dat file from another machine
(which is what I was doing)
2) the trace_clock of the machine could have changed since the trace was
run.
-- Steve
prev parent reply other threads:[~2021-06-22 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 21:13 [PATCH] trace-cmd split: Copy trace_clock from input handler to output handler Steven Rostedt
2021-06-22 21:25 ` Julia Lawall
2021-06-22 21:38 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622173843.496b0ca3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=julia.lawall@inria.fr \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).