linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v4 5/7] libtracefs: Implement tracefs_kprobe_clear_all() to remove all kprobes
Date: Fri, 2 Jul 2021 07:35:09 -0400	[thread overview]
Message-ID: <20210702073509.1b1d8b59@rorschach.local.home> (raw)
In-Reply-To: <e01fb2ef-a51f-f573-3869-829dd93f777d@gmail.com>

On Fri, 2 Jul 2021 14:15:44 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> > diff --git a/src/tracefs-kprobes.c b/src/tracefs-kprobes.c
> > index e875d6e8a65f..fe61a25baa10 100644
> > --- a/src/tracefs-kprobes.c
> > +++ b/src/tracefs-kprobes.c
> > @@ -169,3 +169,106 @@ char **tracefs_get_kprobes(void)
> >   	list = NULL;
> >   	goto out;
> >   }
> > +
> > +struct instance_list {
> > +	struct instance_list	*next;
> > +	struct tracefs_instance	*instance;
> > +};  
> 
> This is not used in this source file. I see that it was moved to 
> tracefs-instance.c

Internally, this was my fourth iteration between v2 and v3, and I kept
finding "better" ways to write this code. This was left over from one
of those iterations.

I'll nuke it. Thanks!

-- Steve

  reply	other threads:[~2021-07-02 11:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  3:54 [PATCH v4 0/7] libtracefs: Facilitate adding and removing kprobes Steven Rostedt
2021-07-02  3:54 ` [PATCH v4 1/7] libtracefs: Implement tracefs_instances() Steven Rostedt
2021-07-02 11:10   ` Yordan Karadzhov (VMware)
2021-07-02 11:33     ` Steven Rostedt
2021-07-02 11:39       ` Yordan Karadzhov (VMware)
2021-07-02 11:50         ` Steven Rostedt
2021-07-02  3:54 ` [PATCH v4 2/7] libtracefs: Implement tracefs_kprobe_raw() Steven Rostedt
2021-07-02  3:54 ` [PATCH v4 3/7] libtracefs: Implement tracefs_kretprobe_raw() Steven Rostedt
2021-07-02  3:54 ` [PATCH v4 4/7] libtracefs: Implement tracefs_get_kprobes() Steven Rostedt
2021-07-02  3:54 ` [PATCH v4 5/7] libtracefs: Implement tracefs_kprobe_clear_all() to remove all kprobes Steven Rostedt
2021-07-02 11:15   ` Yordan Karadzhov (VMware)
2021-07-02 11:35     ` Steven Rostedt [this message]
2021-07-02  3:54 ` [PATCH v4 6/7] libtracefs: Implement tracefs_kprobe_clear_probe() Steven Rostedt
2021-07-02  3:54 ` [PATCH v4 7/7] libtracefs: Add man pages for kprobe functions Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702073509.1b1d8b59@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    --subject='Re: [PATCH v4 5/7] libtracefs: Implement tracefs_kprobe_clear_all() to remove all kprobes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox