Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] libtracefs: Remove leftover regcomp() in event_enable_disable()
@ 2021-07-02 11:43 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2021-07-02 11:43 UTC (permalink / raw)
  To: Linux Trace Devel

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

When adding a helper function to perform the regex compiling
(make_regex()), one place left the open coded compiling but still added
the wrapper function.

Link: https://lore.kernel.org/linux-trace-devel/48ad3a02-f4bf-1579-df6a-f4dc206a7e4e@gmail.com/

Reported-by: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Fixes: de8592c0ef ("libtracefs: Fix tracefs_event_enable/disable() to not have open regex")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 src/tracefs-events.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/tracefs-events.c b/src/tracefs-events.c
index b6d3136..568bfe6 100644
--- a/src/tracefs-events.c
+++ b/src/tracefs-events.c
@@ -868,7 +868,6 @@ static int event_enable_disable(struct tracefs_instance *instance,
 
 	if (system) {
 		ret = make_regex(&system_re, system);
-		ret = regcomp(&system_re, system, REG_ICASE|REG_NOSUB);
 		if (ret < 0)
 			goto out_free;
 	}
-- 
2.31.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 11:43 [PATCH] libtracefs: Remove leftover regcomp() in event_enable_disable() Steven Rostedt

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git