From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC78C4338F for ; Mon, 26 Jul 2021 13:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4752760F44 for ; Mon, 26 Jul 2021 13:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233788AbhGZNIW (ORCPT ); Mon, 26 Jul 2021 09:08:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:33982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233719AbhGZNIW (ORCPT ); Mon, 26 Jul 2021 09:08:22 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB44460F23; Mon, 26 Jul 2021 13:48:50 +0000 (UTC) Date: Mon, 26 Jul 2021 09:48:49 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 3/4] trace-cruncher: Allow for detachable instances Message-ID: <20210726094849.5cfb4afb@oasis.local.home> In-Reply-To: References: <20210712123242.223500-1-y.karadz@gmail.com> <20210712123242.223500-3-y.karadz@gmail.com> <20210722171930.608c8926@oasis.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 26 Jul 2021 12:04:51 +0300 "Yordan Karadzhov (VMware)" wrote: > I think there must be some notice that it is up to the user to take care > about this new instance. This essentially detaches the instance from the > garbage collection, which is quite something in the Python world. > > Maybe we can change the message with something more appropriate? Can't the documentation on the use case be sufficient? I mean, if you have a script that does this, and you give this script to your customers, it would be annoying to have this message appear to your customers where they have no idea what it means. If anything, it should only be printed if you enable some sort of "debug level", like we started doing with the trace libraries. -- Steve