From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F520C4338F for ; Fri, 13 Aug 2021 02:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78CAA610CC for ; Fri, 13 Aug 2021 02:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238458AbhHMCYM (ORCPT ); Thu, 12 Aug 2021 22:24:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:47340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238130AbhHMCYH (ORCPT ); Thu, 12 Aug 2021 22:24:07 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21CFA60F51; Fri, 13 Aug 2021 02:23:41 +0000 (UTC) Date: Thu, 12 Aug 2021 22:23:34 -0400 From: Steven Rostedt To: victorcora98@gmail.com Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH] trace-cmd: Add dependencies to BUILDING section in README Message-ID: <20210812222334.4d486f21@oasis.local.home> In-Reply-To: <20210812223353.28135-1-victorcora98@gmail.com> References: <20210812223353.28135-1-victorcora98@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 12 Aug 2021 19:33:53 -0300 victorcora98@gmail.com wrote: > From: Victor Cora Colombo > > KernelShark has instructions in its README on how to get necessary > dependencies to build it. trace-cmd could follow this example and > also add more information on how to build it. > > This patch adds instructions to README on how to get necessary libraries > and dependencies to build trace-cmd. Thanks for sending this. > > Signed-off-by: Victor Cora Colombo > --- > README | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/README b/README > index 1153152..16aedac 100644 > --- a/README > +++ b/README > @@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB). > > BUILDING: > > +In order to install build dependencies on Ubuntu do the following: > + sudo apt-get install build-essential git pkg-config bison flex -y Note, once the libtracefs settles down, I plan on committing the files that are generated by bison and flex, so it shouldn't be a requirement once libtracefs 1.3 is officially released. That is, because the files generated by flex and bison will be included in the repository, you do not need to include bison or flex to build it. Unless you plan on modifying the bison and flex source files. Also, can we have a Fedora version? If you don't know what that is, I could come up with the equivalents. -- Steve > + > +To install required dependencies: > + git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/ > + cd libtraceevent > + make > + sudo make install > + > + git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/ > + cd libtracefs > + make > + sudo make install > + > To make trace-cmd > make >