linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] trace-cruncher: Refactor instances and kprobes
Date: Thu, 19 Aug 2021 15:54:12 -0400	[thread overview]
Message-ID: <20210819155412.0a6fe8bf@oasis.local.home> (raw)
In-Reply-To: <20210819130827.12327-1-y.karadz@gmail.com>

On Thu, 19 Aug 2021 16:08:20 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> We simplify the way kprobes and tracefs instances are handled by
> the Python module.  The need of storing all kprobes and instances
> created by the module in a binary search tree is eliminated by
> defining new custom Python types for those objects.
> 
> Changes in v2:
>  - Adding patches [PATCH 3/7, 6/7, 7/7]

Hi Yordan,

I took a look over these patches and they all look fine to me.

-- Steve

> 
> 
> Yordan Karadzhov (VMware) (7):
>   trace-cruncher: Use proper naming in common.h
>   trace-cruncher: Add type checking for the custom Python types
>   trace-cruncher: Allow for detachable custom objects
>   trace-cruncher: Define Python type for instances
>   trace-cruncher: Refactor the way libtracefs instances are handled
>   trace-cruncher: Define Python type for kprobes
>   trace-cruncher: Refactor the way kprobes are handled
> 
>  src/common.h                                  |  34 +-
>  src/ftracepy-utils.c                          | 669 +++++++-----------
>  src/ftracepy-utils.h                          |  65 +-
>  src/ftracepy.c                                | 145 ++--
>  tests/1_unit/test_01_ftracepy_unit.py         | 288 +++-----
>  .../test_01_ftracepy_integration.py           |  56 +-
>  tracecruncher/ft_utils.py                     |  14 +-
>  7 files changed, 530 insertions(+), 741 deletions(-)
> 


      parent reply	other threads:[~2021-08-19 19:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 13:08 [PATCH v2 0/7] trace-cruncher: Refactor instances and kprobes Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 1/7] trace-cruncher: Use proper naming in common.h Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 2/7] trace-cruncher: Add type checking for the custom Python types Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 3/7] trace-cruncher: Allow for detachable custom objects Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 4/7] trace-cruncher: Define Python type for instances Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 5/7] trace-cruncher: Refactor the way libtracefs instances are handled Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 6/7] trace-cruncher: Define Python type for kprobes Yordan Karadzhov (VMware)
2021-08-19 13:08 ` [PATCH v2 7/7] trace-cruncher: Refactor the way kprobes are handled Yordan Karadzhov (VMware)
2021-08-19 19:54 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210819155412.0a6fe8bf@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).