From: "John 'Warthog9' Hawley (VMware)" <warthog9@eaglescrag.net>
To: rostedt@goodmis.org, linux-trace-devel@vger.kernel.org
Subject: [PATCH 1/2] libtracefs: sqlhist - fix build dependency
Date: Fri, 20 Aug 2021 16:50:42 -0700 [thread overview]
Message-ID: <20210820235043.1450620-2-warthog9@eaglescrag.net> (raw)
In-Reply-To: <20210820235043.1450620-1-warthog9@eaglescrag.net>
Minor race condition (that's shockingly hard to reproduce, though nearly
always reproducible in an rpmbuild) with sqlhist.tab.h being built after
it's needed by tracefs-sqlhist.c. This just sets an explicit dependency
for tracefs-sqlhist.o on sqlhist.tab.h existing first
Signed-off-by: John 'Warthog9' Hawley (VMware) <warthog9@eaglescrag.net>
---
src/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/Makefile b/src/Makefile
index 9248efc..314c16c 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -64,3 +64,5 @@ dep_includes := $(wildcard $(DEPS))
ifneq ($(dep_includes),)
include $(dep_includes)
endif
+
+$(bdir)/tracefs-sqlhist.o tracefs-sqlhist.o: sqlhist.tab.h
--
2.26.3
next prev parent reply other threads:[~2021-08-20 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 23:50 [Patch v2] Fixing build issues found while working on packaging John 'Warthog9' Hawley (VMware)
2021-08-20 23:50 ` John 'Warthog9' Hawley (VMware) [this message]
2021-08-20 23:50 ` [PATCH 2/2] libtracefs: make the libtracefs.a gen more robust John 'Warthog9' Hawley (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820235043.1450620-2-warthog9@eaglescrag.net \
--to=warthog9@eaglescrag.net \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).