From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 19/20] trace-cmd record: Add compression to the trace context
Date: Tue, 14 Sep 2021 16:16:44 +0300 [thread overview]
Message-ID: <20210914131645.3966308-20-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210914131645.3966308-1-tz.stoyanov@gmail.com>
As the trace-cmd library supports trace file compression, trace-cmd
record command should have a way to configure this functionality. Trace
context is extended to hold the compression algorithm, used to
compress the file.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
tracecmd/trace-record.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index fb6de81b..72592c60 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -199,6 +199,7 @@ struct common_record_context {
char *date2ts;
char *user;
const char *clock;
+ const char *compression;
struct tsc_nsec tsc2nsec;
int data_flags;
int tsync_loop_interval;
@@ -3702,6 +3703,12 @@ static struct tracecmd_output *create_net_output(struct common_record_context *c
goto error;
if (tracecmd_output_set_msg(out, msg_handle))
goto error;
+ if (ctx->compression) {
+ if (tracecmd_output_set_compression(out, ctx->compression))
+ goto error;
+ } else if (ctx->file_version >= FILE_VERSION_COMPRESSION) {
+ tracecmd_output_set_compression(out, "any");
+ }
if (tracecmd_output_write_headers(out, listed_events))
goto error;
@@ -3748,6 +3755,12 @@ setup_connection(struct buffer_instance *instance, struct common_record_context
goto error;
if (tracecmd_output_set_version(network_handle, ctx->file_version))
goto error;
+ if (ctx->compression) {
+ if (tracecmd_output_set_compression(network_handle, ctx->compression))
+ goto error;
+ } else if (ctx->file_version >= FILE_VERSION_COMPRESSION) {
+ tracecmd_output_set_compression(network_handle, "any");
+ }
if (tracecmd_output_write_headers(network_handle, listed_events))
goto error;
tracecmd_set_quiet(network_handle, quiet);
@@ -4481,6 +4494,12 @@ static struct tracecmd_output *create_output(struct common_record_context *ctx)
goto error;
if (ctx->file_version && tracecmd_output_set_version(out, ctx->file_version))
goto error;
+ if (ctx->compression) {
+ if (tracecmd_output_set_compression(out, ctx->compression))
+ goto error;
+ } else if (ctx->file_version >= FILE_VERSION_COMPRESSION) {
+ tracecmd_output_set_compression(out, "any");
+ }
if (tracecmd_output_write_headers(out, listed_events))
goto error;
return out;
@@ -4516,7 +4535,7 @@ static void record_data(struct common_record_context *ctx)
if (latency) {
handle = tracecmd_create_file_latency(ctx->output, local_cpu_count,
- ctx->file_version, NULL);
+ ctx->file_version, ctx->compression);
tracecmd_set_quiet(handle, quiet);
} else {
if (!local_cpu_count)
--
2.31.1
next prev parent reply other threads:[~2021-09-14 13:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 13:16 [PATCH v2 00/20] Trace file version 7 - compression Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 01/20] trace-cmd library: Add support for compression algorithms Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 02/20] trace-cmd library: Internal helpers for compressing data Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 03/20] trace-cmd library: Internal helpers for uncompressing data Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 04/20] trace-cmd library: Inherit compression algorithm from input file Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 05/20] trace-cmd library: New API to configure compression on an output handler Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 06/20] trace-cmd library: Write compression header in the trace file Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 07/20] trace-cmd library: Compress part of " Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 08/20] trace-cmd library: Add local helper function for data compression Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 09/20] trace-cmd library: Compress the trace data Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 10/20] trace-cmd library: Decompress the options section, if it is compressed Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 11/20] trace-cmd library: Read compression header Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 12/20] trace-cmd library: Extend the input handler with trace data decompression context Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 13/20] trace-cmd library: Initialize CPU data decompression logic Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 14/20] trace-cmd library: Add logic for in-memory decompression Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 15/20] trace-cmd library: Read compressed latency data Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 16/20] trace-cmd library: Decompress file sections on reading Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 17/20] trace-cmd library: Add zlib compression algorithm Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` [PATCH v2 18/20] trace-cmd list: Show supported compression algorithms Tzvetomir Stoyanov (VMware)
2021-09-14 13:16 ` Tzvetomir Stoyanov (VMware) [this message]
2021-09-14 13:16 ` [PATCH v2 20/20] trace-cmd report: Add new parameter for trace file compression Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914131645.3966308-20-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).