From: John Keeping <john@metanate.com>
To: linux-trace-devel@vger.kernel.org
Cc: Yordan Karadzhov <y.karadz@gmail.com>, John Keeping <john@metanate.com>
Subject: [PATCH] kernel-shark: Handle traces with sched_wakeup but not sched_waking
Date: Thu, 23 Sep 2021 15:06:43 +0100 [thread overview]
Message-ID: <20210923140643.3975473-1-john@metanate.com> (raw)
If sched_wakeup or sched_wakeup_new is avaiable but sched_waking is not,
then define_wakeup_event() returns true even though waking_event_ptr is
null.
Change find_wakeup_event() to avoid overwriting the output parameter on
error so that the define_wakeup_event() returns true iff
*waking_event_ptr is non-null.
Signed-off-by: John Keeping <john@metanate.com>
---
src/libkshark-tepdata.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/libkshark-tepdata.c b/src/libkshark-tepdata.c
index 865ca82..9740ed9 100644
--- a/src/libkshark-tepdata.c
+++ b/src/libkshark-tepdata.c
@@ -1868,9 +1868,14 @@ int kshark_tep_find_top_stream(struct kshark_context *kshark_ctx,
static bool find_wakeup_event(struct tep_handle *tep, const char *wakeup_name,
struct tep_event **waking_event_ptr)
{
- *waking_event_ptr = tep_find_event_by_name(tep, "sched", wakeup_name);
+ struct tep_event *event;
+
+ event = tep_find_event_by_name(tep, "sched", wakeup_name);
+
+ if (event)
+ *waking_event_ptr = event;
- return (*waking_event_ptr)? true : false;
+ return !!event;
}
/**
--
2.33.0
next reply other threads:[~2021-09-23 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 14:06 John Keeping [this message]
2021-09-27 9:56 ` [PATCH] kernel-shark: Handle traces with sched_wakeup but not sched_waking Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923140643.3975473-1-john@metanate.com \
--to=john@metanate.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).