linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH] libtraceevent: A new API for trace page size
Date: Fri,  1 Oct 2021 09:23:38 +0300	[thread overview]
Message-ID: <20211001062338.2389024-1-tz.stoyanov@gmail.com> (raw)

Currently, the size of a trace buffer page is equal to the system memory
page size. This may change in the future, so this assumption may not be
valid. The proper way to determine the trace buffer page size is by
using the information from "events/header_page" ftrace file:
 ...
 field: char data;	offset:16;	size:4080;	signed:1;
The trace buffer page size is the size of the "data" filed + its offset.

A new libtraceevent API is introduced, for getting the trace buffer page
size using that formula:
 tep_get_trace_page_size()

Note, that some old kernels may not have "events/header_page" file. For
those, the API returns the system memory page size.

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 src/event-parse-api.c | 16 ++++++++++++++++
 src/event-parse.h     |  1 +
 2 files changed, 17 insertions(+)

diff --git a/src/event-parse-api.c b/src/event-parse-api.c
index f8361e4..b5be8d3 100644
--- a/src/event-parse-api.c
+++ b/src/event-parse-api.c
@@ -4,6 +4,7 @@
  *
  */
 
+#include <unistd.h>
 #include "event-parse.h"
 #include "event-parse-local.h"
 #include "event-utils.h"
@@ -248,6 +249,21 @@ void tep_set_page_size(struct tep_handle *tep, int _page_size)
 		tep->page_size = _page_size;
 }
 
+/**
+ * tep_get_trace_page_size - get the size of a trace page on the traced machine
+ * @tep: a handle to the tep_handle
+ *
+ * This returns the size of a trace page on the traced machine
+ * If @tep is NULL or the kernel is old, user space page size is returned.
+ */
+int tep_get_trace_page_size(struct tep_handle *tep)
+{
+	if (tep && !tep->old_format)
+		return tep->header_page_data_size + tep->header_page_data_offset;
+
+	return getpagesize();
+}
+
 /**
  * tep_is_file_bigendian - return the endian of the file
  * @tep: a handle to the tep_handle
diff --git a/src/event-parse.h b/src/event-parse.h
index 0833893..ea8df35 100644
--- a/src/event-parse.h
+++ b/src/event-parse.h
@@ -572,6 +572,7 @@ void tep_set_cpus(struct tep_handle *tep, int cpus);
 int tep_get_long_size(struct tep_handle *tep);
 void tep_set_long_size(struct tep_handle *tep, int long_size);
 int tep_get_page_size(struct tep_handle *tep);
+int tep_get_trace_page_size(struct tep_handle *tep);
 void tep_set_page_size(struct tep_handle *tep, int _page_size);
 bool tep_is_file_bigendian(struct tep_handle *tep);
 void tep_set_file_bigendian(struct tep_handle *tep, enum tep_endian endian);
-- 
2.31.1


             reply	other threads:[~2021-10-01  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01  6:23 Tzvetomir Stoyanov (VMware) [this message]
2021-11-11 15:25 ` [PATCH] libtraceevent: A new API for trace page size Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001062338.2389024-1-tz.stoyanov@gmail.com \
    --to=tz.stoyanov@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).