linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Subject: [PATCH 01/10] libtraceevent: Fix installing of man pages in remote directory
Date: Thu, 16 Dec 2021 16:39:47 -0500	[thread overview]
Message-ID: <20211216213956.13934-2-rostedt@goodmis.org> (raw)
In-Reply-To: <20211216213956.13934-1-rostedt@goodmis.org>

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

When the building of the man pages is done in a directory other than the
repo directory (with the O= option), the intermediate build file name
incorrectly appends a "install-" prefix to the path and not to the file,
causing the installation to fail.

Fix it by using patsubst instead of addprefix to append the "install-"
name to the intermediate files for the installation.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 Documentation/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index 73dbe2ae4d43..af124572c863 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -154,12 +154,12 @@ ifdef missing_tools
 	$(error "You need to install $(missing_tools) for man pages")
 endif
 
-install-%.3: $(OUTPUT)%.3
+$(OUTPUT)install-%.3: $(OUTPUT)%.3
 	$(call QUIET_INSTALL, $<) \
 		$(INSTALL) -d -m 755 $(DESTDIR)$(man3dir); \
 		$(INSTALL) -m 644 $< $(DESTDIR)$(man3dir);
 
-do-install-man: man $(addprefix install-,$(wildcard $(OUTPUT)*.3))
+do-install-man: man $(patsubst $(OUTPUT)%,$(OUTPUT)install-%,$(wildcard $(OUTPUT)*.3))
 
 install-man: check-man-tools man
 	$(Q)$(MAKE) -C . do-install-man
-- 
2.33.0


  reply	other threads:[~2021-12-16 21:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 21:39 [PATCH 00/10] libtraceevent: Makefile updates fixes and unit tests Steven Rostedt
2021-12-16 21:39 ` Steven Rostedt [this message]
2021-12-16 21:39 ` [PATCH 02/10] libtraceevent: Rewrite Makefiles to be like libtracefs Steven Rostedt
2021-12-16 21:39 ` [PATCH 03/10] libtraceevent: Have make tags and TAGS honor O= build directory Steven Rostedt
2021-12-16 21:39 ` [PATCH 04/10] libtraceevent: Move installed headers into their own directory Steven Rostedt
2021-12-16 21:39 ` [PATCH 05/10] libtraceevent: Add unit test framework for library commands Steven Rostedt
2021-12-16 21:39 ` [PATCH 06/10] libtraceveent: Add testing of old dynamic string event layout Steven Rostedt
2021-12-16 21:39 ` [PATCH 07/10] libraceevent: Add unit test to test print_fmt with dynamic strings Steven Rostedt
2021-12-16 21:39 ` [PATCH 08/10] libtraceevent: Account for old dynamic string formats and honor size Steven Rostedt
2021-12-16 21:39 ` [PATCH 09/10] libtraceevent: Replace tep_print_field() with tep_print_field_content() Steven Rostedt
2021-12-16 21:39 ` [PATCH 10/10] libtraceevent: Have print_field_raw() handle old data layout Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211216213956.13934-2-rostedt@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).