From: Solomon Tan <wjsota@gmail.com>
To: y.karadz@gmail.com
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH 1/2] kernel-shark: Make FreeSans a compulsory component
Date: Wed, 20 Apr 2022 23:38:26 +0800 [thread overview]
Message-ID: <20220420153827.637413-1-wjsota@gmail.com> (raw)
In-Reply-To: <YmAkAE+5wy2mLncD@ArchDesktop>
This patch is proposed for two reasons.
Firstly, with reference to
https://lore.kernel.org/linux-trace-devel/Yl9WBztqKGD0PpmJ@ArchDesktop/
when the CMake does not detect FreeSans, it should cease generating the
Makefile since kernelshark requires FreeSans to output its graph
properly.
Secondly, when the make instructions on the README are followed, even
when FreeSans is not detected, `make` continues to compile and `make
install` (or `install_gui`) would install without indicating an error.
This gives the impression of a successful install, but `kernelshark`
will be missing.
Therefore, making CMake quit with error when FreeSans is not installed
solves these two issues.
Signed-off-by: Solomon Tan <wjsota@gmail.com>
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e6a76d8..5473bfa 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -69,7 +69,7 @@ if (TT_FONT_FILE)
else (TT_FONT_FILE)
- message(WARNING "\nCould not find font ${KS_FONT}!\n")
+ message(FATAL_ERROR "\nCould not find font ${KS_FONT}!\n")
endif (TT_FONT_FILE)
--
2.36.0
next prev parent reply other threads:[~2022-04-20 15:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:48 Kernelshark v2 all-black plots area Dario Faggioli
2021-02-09 13:06 ` Yordan Karadzhov (VMware)
2021-02-09 16:13 ` Dario Faggioli
2021-02-10 11:21 ` Yordan Karadzhov (VMware)
2021-02-10 14:51 ` Dario Faggioli
2021-02-10 15:47 ` Yordan Karadzhov (VMware)
2021-02-10 16:15 ` Dario Faggioli
2021-02-10 16:23 ` Steven Rostedt
2022-04-20 0:38 ` Solomon Tan
2022-04-20 8:06 ` Yordan Karadzhov
2022-04-20 15:17 ` Solomon Tan
2022-04-20 15:38 ` Solomon Tan [this message]
2022-04-20 15:38 ` [PATCH 2/2] kernel-shark: Allow FreeSans otf in addition to ttf Solomon Tan
2022-04-21 12:16 ` Yordan Karadzhov
2022-04-21 12:04 ` [PATCH 1/2] kernel-shark: Make FreeSans a compulsory component Yordan Karadzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420153827.637413-1-wjsota@gmail.com \
--to=wjsota@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).