* [PATCH] trace-cmd library: Fix chunk_cmp()
@ 2022-06-08 14:48 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2022-06-08 14:48 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The binary search looking for an address in the compressed chunks was
failing when it should have found a chunk. The reason is that the order of
the offsets is in ascending order, but the search was looking as if it was
in descending order.
Fixes: 6a724f21bbbe1 ("trace-cmd library: Add logic for in-memory decompression")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index e2ceff331869..fea991ce732c 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -1285,7 +1285,7 @@ static int chunk_cmp(const void *A, const void *B)
if (CHUNK_CHECK_OFFSET(b, a->offset))
return 0;
- if (b->offset < a->offset)
+ if (a->offset < b->offset)
return -1;
return 1;
--
2.35.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-08 14:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08 14:48 [PATCH] trace-cmd library: Fix chunk_cmp() Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).