From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2953BC43334 for ; Wed, 8 Jun 2022 17:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbiFHRT2 (ORCPT ); Wed, 8 Jun 2022 13:19:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbiFHRR1 (ORCPT ); Wed, 8 Jun 2022 13:17:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B42A419047 for ; Wed, 8 Jun 2022 10:05:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B2D6861AC3 for ; Wed, 8 Jun 2022 17:05:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0D26C34116; Wed, 8 Jun 2022 17:05:28 +0000 (UTC) Date: Wed, 8 Jun 2022 13:05:27 -0400 From: Steven Rostedt To: Linux Trace Devel Cc: Johannes Berg Subject: [PATCH] trace-cmd record: Verify that splice works before using it Message-ID: <20220608130527.26e50cba@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: "Steven Rostedt (Google)" Add a test to make sure that splice works on the source directory before using it, and if not automatically switch over to read/write method. Suggested-by: Johannes Berg Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213659 Signed-off-by: Steven Rostedt (Google) --- Johannes, can you test this? I want to make sure that it fixes the issue. lib/trace-cmd/trace-recorder.c | 38 ++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c index c83337899098..c7ef13c851d2 100644 --- a/lib/trace-cmd/trace-recorder.c +++ b/lib/trace-cmd/trace-recorder.c @@ -220,6 +220,41 @@ tracecmd_create_buffer_recorder_fd2(int fd, int fd2, int cpu, unsigned flags, return NULL; } +static void verify_splice(const char *file, unsigned *flags) +{ + int brass[2]; + int ret; + int fd; + + fd = open(file, O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE, 0644); + if (fd < 0) + return; /* Will fail by the caller too */ + + if (pipe(brass) < 0) + goto fail_pipe; + + ret = splice(brass[0], NULL, fd, NULL, 0, SPLICE_F_NONBLOCK); + if (ret < 0) + goto fail_splice; + + out_pipe: + close(brass[0]); + close(brass[1]); + out: + close(fd); + return; + + fail_pipe: + tracecmd_warning("Failed opening pipe, trying read/write"); + *flags |= TRACECMD_RECORD_NOSPLICE; + goto out; + + fail_splice: + tracecmd_warning("Failed splice to file, trying read/write"); + *flags |= TRACECMD_RECORD_NOSPLICE; + goto out_pipe; +} + struct tracecmd_recorder * tracecmd_create_buffer_recorder_fd(int fd, int cpu, unsigned flags, const char *buffer) { @@ -233,6 +268,9 @@ __tracecmd_create_buffer_recorder(const char *file, int cpu, unsigned flags, struct tracecmd_recorder *recorder; int fd; + if (!(flags & TRACECMD_RECORD_NOSPLICE)) + verify_splice(file, &flags); + fd = open(file, O_WRONLY | O_CREAT | O_TRUNC | O_LARGEFILE, 0644); if (fd < 0) return NULL; -- 2.35.1