From: Andreas Ziegler <br015@umbiko.net>
To: Daniel Bristot de Oliveira <bristot@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Ziegler <br015@umbiko.net>
Subject: [PATCH 0/2 v2] rtla osnoise hist average calculation
Date: Tue, 3 Jan 2023 11:33:58 +0100 [thread overview]
Message-ID: <20230103103400.275566-1-br015@umbiko.net> (raw)
In-Reply-To: <f47e877c-c95f-e3e6-b96f-89b0ca582878@kernel.org>
Version 2 of the proposed patch, with changes split in two separate commits,
as suggested by Daniel Bristot de Oliveira
rtla osnoise hist always outputs '0' as average duration value. Example:
# rtla osnoise hist -P F:1 -c 0-1 -r 900000 -d 1M -b 1 -E 5000 -T 1
# RTLA osnoise histogram
# Time unit is microseconds (us)
# Duration: 0 00:01:00
...
count: 5629 1364
min: 1 1
avg: 0 0
max: 2955 56
This is due to sum_sample in osnoise_hist_update_multiple() being calculated
as the sum (duration), not as sum (duration * count).
Truncating of the average value in final output suggests too optimistic
results; display floating point value instead.
Andreas Ziegler (2):
tools/tracing/rtla: osnoise_hist: use total duration for average
calculation
tools/tracing/rtla: osnoise_hist: display average with two-digit
precision
tools/tracing/rtla/src/osnoise_hist.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
2.34.1
next prev parent reply other threads:[~2023-01-03 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 12:39 rtla osnoise hist: average duration is always zero Andreas Ziegler
2022-12-24 21:17 ` Slade Watkins
2022-12-26 11:50 ` Andreas Ziegler
2022-12-28 15:25 ` Daniel Bristot de Oliveira
2023-01-03 10:33 ` Andreas Ziegler [this message]
2023-01-03 10:33 ` [PATCH 1/2 v2] tools/tracing/rtla: osnoise_hist: use total duration for average calculation Andreas Ziegler
2023-01-12 14:32 ` Daniel Bristot de Oliveira
2023-01-03 10:34 ` [PATCH 2/2 v2] tools/tracing/rtla: osnoise_hist: display average with two-digit precision Andreas Ziegler
2023-01-12 14:33 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103103400.275566-1-br015@umbiko.net \
--to=br015@umbiko.net \
--cc=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).