From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Ching-lin Yu <chinglinyu@google.com>
Subject: [PATCH] libtracefs: Fix tracefs_instance_set_buffer_size() for individual CPUs
Date: Tue, 3 Jan 2023 18:38:46 -0500 [thread overview]
Message-ID: <20230103183846.5ffdef36@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The tracefs_instance_set_buffer_size() function, when passed an update for
an individual CPU, writes in "val" and not val (the string that holds the
value to set). This is obviously wrong. Fix it.
Fixes: 48c026fbb430e ("libtracefs: Add tracefs_instance_set_buffer_size() API")
Reported-by: Ching-lin Yu <chinglinyu@google.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
src/tracefs-instance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c
index 6905f61ff929..57f5c7f9a000 100644
--- a/src/tracefs-instance.c
+++ b/src/tracefs-instance.c
@@ -419,7 +419,7 @@ int tracefs_instance_set_buffer_size(struct tracefs_instance *instance, size_t s
return ret;
}
- ret = tracefs_instance_file_write(instance, path, "val");
+ ret = tracefs_instance_file_write(instance, path, val);
free(path);
}
free(val);
--
2.35.1
reply other threads:[~2023-01-03 23:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103183846.5ffdef36@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chinglinyu@google.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).