From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Sojka <michal.sojka@cvut.cz>
Cc: linux-trace-devel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>, Jan Engelhardt <jengelh@inai.de>
Subject: Re: [PATCH] trace-cmd: Allow building with GNU Make 4.4
Date: Tue, 3 Jan 2023 23:09:25 -0500 [thread overview]
Message-ID: <20230103230925.41dfdd8f@gandalf.local.home> (raw)
In-Reply-To: <20221226164951.2632069-1-michal.sojka@cvut.cz>
On Mon, 26 Dec 2022 17:49:51 +0100
Michal Sojka <michal.sojka@cvut.cz> wrote:
> Make 4.4 introduces several backward incompatibilities and the result
> is that building trace-cmd with it never finishes. It seems that make
> ends up in some kind of infinite recursion. The symptoms are:
>
> $ make -d
> GNU Make 4.4
> Built for x86_64-pc-linux-gnu
> Copyright (C) 1988-2022 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> Reading makefiles...
> Reading makefile 'Makefile'...
> Makefile:79: not recursively expanding pkgconfig_dir to export to shell function
> Makefile:79: not recursively expanding pkgconfig_dir to export to shell function
> Makefile:224: not recursively expanding LIBTRACECMD_SHARED_VERSION to export to shell function
> Makefile:79: not recursively expanding pkgconfig_dir to export to shell function
> Makefile:224: not recursively expanding LIBTRACECMD_SHARED_VERSION to export to shell function
> Makefile:225: not recursively expanding LIBTRACECMD_SHARED_SO to export to shell function
> Makefile:79: not recursively expanding pkgconfig_dir to export to shell function
> Makefile:79: not recursively expanding pkgconfig_dir to export to shell function
>
> Build succeeds if recursively expanded variables (defined with '='),
> which use $(shell ...) as its value, are replaced with simply expanded
> variables (defined with ':=').
>
> Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
> ---
Applied. Thanks Michal!
-- Steve
prev parent reply other threads:[~2023-01-04 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 16:49 [PATCH] trace-cmd: Allow building with GNU Make 4.4 Michal Sojka
2023-01-02 8:52 ` Daniel Wagner
2023-01-04 4:09 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103230925.41dfdd8f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dwagner@suse.de \
--cc=jengelh@inai.de \
--cc=linux-trace-devel@vger.kernel.org \
--cc=michal.sojka@cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).