From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B25C63797 for ; Tue, 10 Jan 2023 15:10:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234164AbjAJPJm (ORCPT ); Tue, 10 Jan 2023 10:09:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238898AbjAJPJR (ORCPT ); Tue, 10 Jan 2023 10:09:17 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 074D35D410; Tue, 10 Jan 2023 07:08:29 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9E7CD772FE; Tue, 10 Jan 2023 15:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1673363307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yMbfvw9VPhE4xhx9UJlu8IMWthM+lSG29AO9lWd2ERk=; b=HIFyKH+16P3kVvQ2Ml5w5VXXiMvn9nLN2x7nVlYmiOfz+FIq8kFB40luGChq4q2WKCCFBS dByMFrJnSegbAb2P9hUUBarIBYZXp2myBfacrljj5+nDmbbI+KGF8AMHjFTEF8uQFacG/H DZBru62KB5LE/ENqkHtbK98dbKqAzqU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1673363307; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yMbfvw9VPhE4xhx9UJlu8IMWthM+lSG29AO9lWd2ERk=; b=Z6CmRom1jLM6Z2Lr/kcQmHPxdn6a4p8y2H9OC0PYk1BRm/+ujjsFbQ+AmMQSSf2o/sckER 96EM6xsH3izkXKCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9064C1358A; Tue, 10 Jan 2023 15:08:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OCc0I2t/vWPAdQAAMHmgww (envelope-from ); Tue, 10 Jan 2023 15:08:27 +0000 Date: Tue, 10 Jan 2023 16:08:27 +0100 From: Daniel Wagner To: Steven Rostedt Cc: Daniel Bristot de Oliveira , linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/rtla: Explicitly list libtraceevent dependency Message-ID: <20230110150827.chdwhg6h6d4owxai@carbon.lan> References: <20230110131805.16242-1-dwagner@suse.de> <42d1e999-79a6-94dc-cc88-77520ddce068@kernel.org> <20230110140814.2yz4if2e2fasnu7t@carbon.lan> <94fd6fb5-c87a-b02e-40bc-b2e2c99529d5@kernel.org> <20230110144536.knepnpxsp4mw67no@carbon.lan> <20230110095137.18168c29@gandalf.local.home> <20230110095347.3662c3ba@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230110095347.3662c3ba@gandalf.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, Jan 10, 2023 at 09:53:47AM -0500, Steven Rostedt wrote: > On Tue, 10 Jan 2023 09:51:37 -0500 > Steven Rostedt wrote: > > > There's many interfaces that require the libtraceevent header files to work > > with libtracefs. Anything that uses libtracefs must also use libtraceevent, > > as libtracefs is really just an extension of libtraceevent. Okay, in this case I am going update the Meson build to add the necessary explicit dependency: ++ b/src/meson.build @@ -50,6 +50,7 @@ libtracefs_static = static_library( pkg = import('pkgconfig') pkg.generate( libtracefs, + libraries: [libtraceevent_dep], subdirs: 'libtracefs', filebase: meson.project_name(), name: meson.project_name(), $ cat /tmp/trace-cmd/lib64/pkgconfig/libtracefs.pc prefix=/tmp/trace-cmd includedir=${prefix}/include libdir=${prefix}/lib64 Name: libtracefs Description: Manage trace fs URL: https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/ Version: 1.6.3 Requires: libtraceevent >= 1.7.0 Libs: -L${libdir} -ltracefs Cflags: -I${includedir}/libtracefs $ PKG_CONFIG_PATH=/tmp/trace-cmd $ pkg-config --libs libtracefs -L/tmp/trace-cmd/lib64 -ltracefs -ltraceevent