From: Steven Rostedt <rostedt@goodmis.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
mathieu.desnoyers@efficios.com, dcook@linux.microsoft.com,
alanau@linux.microsoft.com, brauner@kernel.org,
akpm@linux-foundation.org, ebiederm@xmission.com,
keescook@chromium.org, tglx@linutronix.de,
linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v8 11/11] tracing/user_events: Limit global user_event count
Date: Fri, 24 Mar 2023 13:06:59 -0400 [thread overview]
Message-ID: <20230324130659.587ecfd2@gandalf.local.home> (raw)
In-Reply-To: <20230324164353.GA1790@kbox>
On Fri, 24 Mar 2023 09:43:53 -0700
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> > It was actually merged in 5.8. So sysctl should be sufficient with that.
> > But maybe it's weird to start adding sysctls, when the rest of tracing
> > tunables is AFAIK under /sys/kernel/tracing/ ?
> >
>
> During the TraceFS meetings Steven runs I was asked to add a boot
> parameter and sysctl for user_events to limit the max.
>
> To me, it seems when user_events moves toward namespace awareness
> sysctl might be easier to use from within a namespace to turn knobs.
>
> Happy to change to whatever, but I want to see Steven and Masami agree
> on the approach before doing so.
>
> Steven, do you agree with Masami to move to just sysctl?
We do have some tracing related sysctls already:
# cd /proc/sys/kernel
# ls *trace*
ftrace_dump_on_oops oops_all_cpu_backtrace traceoff_on_warning
ftrace_enabled stack_tracer_enabled tracepoint_printk
Although I would love to deprecated ftrace_enable as that now has a
control in tracefs, but it's not unprecedented to have tracing tunables as
sysctl.
And if we get cmdline boot parameters for free from sysctls then all the
better.
-- Steve
next prev parent reply other threads:[~2023-03-24 17:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 21:11 [PATCH v8 00/11] tracing/user_events: Remote write ABI Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 01/11] tracing/user_events: Split header into uapi and kernel Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 02/11] tracing/user_events: Track fork/exec/exit for mm lifetime Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 03/11] tracing/user_events: Use remote writes for event enablement Beau Belgrave
2023-03-28 20:59 ` Steven Rostedt
2023-02-21 21:11 ` [PATCH v8 04/11] tracing/user_events: Fixup enable faults asyncly Beau Belgrave
2023-03-28 21:20 ` Steven Rostedt
2023-03-28 21:42 ` Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 05/11] tracing/user_events: Add ioctl for disabling addresses Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 06/11] tracing/user_events: Update self-tests to write ABI Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 07/11] tracing/user_events: Add ABI self-test Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 08/11] tracing/user_events: Use write ABI in example Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 09/11] tracing/user_events: Update documentation for ABI Beau Belgrave
2023-03-24 0:06 ` Masami Hiramatsu
2023-03-24 16:47 ` Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 10/11] tracing/user_events: Charge event allocs to cgroups Beau Belgrave
2023-02-21 21:11 ` [PATCH v8 11/11] tracing/user_events: Limit global user_event count Beau Belgrave
2023-03-24 0:18 ` Masami Hiramatsu
2023-03-24 8:54 ` Vlastimil Babka
2023-03-24 16:43 ` Beau Belgrave
2023-03-24 17:06 ` Steven Rostedt [this message]
2023-03-26 15:22 ` Masami Hiramatsu
2023-03-24 0:05 ` [PATCH v8 00/11] tracing/user_events: Remote write ABI Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324130659.587ecfd2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=alanau@linux.microsoft.com \
--cc=beaub@linux.microsoft.com \
--cc=brauner@kernel.org \
--cc=dcook@linux.microsoft.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).