From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Pierre Gondois <pierre.gondois@arm.com>
Subject: [PATCH v2] trace-cmd split: Initialize current in parse_file()
Date: Wed, 24 Jan 2024 12:49:27 -0500 [thread overview]
Message-ID: <20240124124927.3551e982@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The code fix to correctly split start/end/time-window parameters removed
an initialization of "current" which can now fall out being uninitialized
and used for a later compare.
Found with valgrind.
Link: https://lore.kernel.org/linux-trace-devel/20240124122832.4e0b33b7@gandalf.local.home/
Fixes: 1439b8f518 ("trace-cmd split: Correctly split with start/end/time-window parameters")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Changes since v1: https://lore.kernel.org/all/20240124123439.3441eb6f@gandalf.local.home/
- rebase on the fixed commit, not in the middle of the other split patches
tracecmd/trace-split.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index b6c056b5f34b..8c710da15f78 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -358,7 +358,7 @@ static unsigned long long parse_file(struct tracecmd_input *handle,
enum split_types type,
bool *end_reached)
{
- unsigned long long current;
+ unsigned long long current = 0;
struct tracecmd_output *ohandle;
struct cpu_data *cpu_data;
struct tep_record *record;
--
2.43.0
reply other threads:[~2024-01-24 17:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124124927.3551e982@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).