From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org, stephen@brennan.io
Subject: Re: [PATCH v2 1/3] kernel-shark: Provide parsing for quotation marks in Record command line
Date: Fri, 20 Sep 2019 12:48:31 +0300 [thread overview]
Message-ID: <220cd496-9e30-842a-1714-d3f0d90928f9@gmail.com> (raw)
In-Reply-To: <20190919192022.7b9d8918@gandalf.local.home>
On 20.09.19 г. 2:20 ч., Steven Rostedt wrote:
> On Wed, 18 Sep 2019 17:23:17 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
>> +/**
>> + * Separate the command line arguments inside the string taking into account
>> + * possible shell quoting and new lines.
>> + */
>> +QStringList splitArguments(QString cmd)
>> +{
>> + QString::SplitBehavior opt = QString::SkipEmptyParts;
>> + int i, progress = 0, size;
>> + QStringList argv;
>> + QChar quote = 0;
>> +
>> + /* Remove all new lines. */
>> + cmd.replace("\\\n", " ");
>> +
>> + size = cmd.count();
>> + auto lamMid = [&] () {return cmd.mid(progress, i - progress);};
>> + for (i = 0; i < size; ++i) {
>> + if (cmd[i] == '\\') {
>> + cmd.remove(i, 1);
>> + size --;
>> + continue;
>> + }
>> +
>> + if (cmd[i] == '\'' || cmd[i] == '"') {
>> + if (quote.isNull()) {
>> + argv << lamMid().split(" ", opt);
>> + quote = cmd[i++];
>> + progress = i;
>> + } else if (quote == cmd[i]) {
>> + argv << lamMid();
>> + quote = 0;
>> + progress = ++i;
>> + }
>> + }
>> + }
>> +
>> + argv << cmd.right(size - progress).split(" ", opt);
>> +
>> + return argv;
>> +}
>
> I still find the above hard to read, but so be it ;-)
>
> Anyway, not quite yet. I just noticed that if I do:
>
> echo "this \" is \" a \"test"
>
> The output has:
>
> ("echo", "this \" is \" a \"test")
>
Hi Steven,
This is a Qt printing artifact. The printout is trying to show clearly
that this list contain only 2 strings. That is why it adds those
backslashes. In the code of the example, try adding this:
if (ok) {
argList = KsUtils::splitArguments(text);
qInfo() << argList;
+ for (auto a: argList)
+ cout << a.toStdString() << endl;
proc.setProgram(argList.takeFirst());
proc.setArguments(argList);
and you will see what I mean.
Thanks a lot for being a tester!!!
Yordan
>
> We don't want to keep the backslash here. We want to remove it before
> passing it as an argument.
>
> The above should be:
>
> ("echo", "this " is " a "test")
>
> (thinking that you put in the outside quotes. In other words, if I have:
>
> echo "hello \"there\""
>
> We should break that up into:
> arg0=echo
> arg1=hello "there"
>
> -- Steve
>
next prev parent reply other threads:[~2019-09-20 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 14:23 [PATCH v2 0/3] Support "shell quoting" in the Record dialog Yordan Karadzhov (VMware)
2019-09-18 14:23 ` [PATCH v2 1/3] kernel-shark: Provide parsing for quotation marks in Record command line Yordan Karadzhov (VMware)
2019-09-19 23:20 ` Steven Rostedt
2019-09-20 9:48 ` Yordan Karadzhov (VMware) [this message]
2019-09-18 14:23 ` [PATCH v2 2/3] kernel-shark: give more space to the command field of the Record dialog Yordan Karadzhov (VMware)
2019-09-18 14:23 ` [PATCH v2 3/3] kernel-shark: Add quotation marks parsing example/test Yordan Karadzhov (VMware)
2019-09-19 23:12 ` Steven Rostedt
2019-09-20 9:50 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220cd496-9e30-842a-1714-d3f0d90928f9@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stephen@brennan.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).