linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Steven Rostedt <rostedt@goodmis.org>,
	Xiao Yang <yangx.jy@cn.fujitsu.com>,
	linux-kselftest@vger.kernel.org,
	linux-trace-devel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Xiao Yang <ice_yangxiao@163.com>
Subject: Re: [v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation
Date: Wed, 15 Apr 2020 09:12:20 +0200	[thread overview]
Message-ID: <3797d4b4-180e-fb25-09ed-888385c04894@web.de> (raw)
In-Reply-To: <20200414214643.2e14ac76@oasis.local.home>

>>> * Adjustment:
>>>    … operation (i. e. …
>> Hi Markus,
>>
>> Which part of description do you want to change or could you provide an
>> example for reference?

I proposed to insert two space characters in a wording.


> That part is fine for me.

Such a view can be fine if you would like to adjust the provided contents
another bit for the final commit message.


>> Do you mean to add the following "Fixes" tag?
>> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
>
> Yeah, that fixes tag is appropriate.

I suggest to reconsider the influence of parentheses at such places.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=8632e9b5645bbc2331d21d892b0d6961c1a08429#n183

Regards,
Markus

      parent reply	other threads:[~2020-04-15  7:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  7:54 [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation Markus Elfring
2020-04-15  1:40 ` Xiao Yang
2020-04-15  1:46   ` Steven Rostedt
2020-04-15  1:59     ` Xiao Yang
2020-04-15  7:12     ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3797d4b4-180e-fb25-09ed-888385c04894@web.de \
    --to=markus.elfring@web.de \
    --cc=ice_yangxiao@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=yangx.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).