linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
	"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] kernel-shark v2: Change the logic for opening trace-cmd files
Date: Thu, 11 Mar 2021 16:15:59 +0200	[thread overview]
Message-ID: <42d08f5e-d681-715b-9f40-5763c4332394@gmail.com> (raw)
In-Reply-To: <20210310164839.475d10be@gandalf.local.home>



On 10.03.21 г. 23:48, Steven Rostedt wrote:
> On Wed, 10 Mar 2021 14:11:35 +0200
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> 
>> From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
>>
>> The logic for opening a trace file by trace-cmd library has changed.
>> Any timestamp corrections, found in the trace file metadata are applied
>> automatically. The old APIs, used by KernelShark for pairing trace files
>> from the same host-guest traceing session and adjusting timestamps are
> 
>   s/traceing/tracing/
> 
>> now obsolete and should not be used.
>>
>> Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> 
> The from and SOB should be Tzvetomir Stoyanov (VMware), unless you changed
> your middle name to (VMware) ;-)
> 
> As for the rest of the patch.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Hi Steven,

Thanks a lot for the review!

Have you tested that this works with the Timestamp synchronization 
patches that are not upstreamed yet?

Thanks!
Yordan


> 
> -- Steve
> 

  reply	other threads:[~2021-03-11 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 12:11 [PATCH] kernel-shark v2: Change the logic for opening trace-cmd files Tzvetomir Stoyanov (VMware)
2021-03-10 21:48 ` Steven Rostedt
2021-03-11 14:15   ` Yordan Karadzhov (VMware) [this message]
2021-03-11 14:55     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42d08f5e-d681-715b-9f40-5763c4332394@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).