From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F76C63777 for ; Fri, 20 Nov 2020 17:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA2972240B for ; Fri, 20 Nov 2020 17:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="Uw5l71ZN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728891AbgKTRug (ORCPT ); Fri, 20 Nov 2020 12:50:36 -0500 Received: from mail.efficios.com ([167.114.26.124]:39148 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728771AbgKTRuf (ORCPT ); Fri, 20 Nov 2020 12:50:35 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C0C532F9333 for ; Fri, 20 Nov 2020 12:50:34 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id A0EI25EY0exE for ; Fri, 20 Nov 2020 12:50:34 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 7CE942F9332 for ; Fri, 20 Nov 2020 12:50:34 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 7CE942F9332 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1605894634; bh=R1ibHBy4yrxgAfAi0/rXumalIAD+pqYMzDArLQ1r7IE=; h=To:From:Message-ID:Date:MIME-Version; b=Uw5l71ZNHuLDiUoyeiBqMcfQ/oD9mJt5PCdwOs8eHiOufikY9m6LUQ9OU58W8vSM2 47/aOIrtm6NDGXxG3yS0Rg5LOZ43k0H5gIpegUGxtcia5wnplUWCHFhgtHVSAfG3DC J2c2iSkdPuYTYxqvFTI00Slsp3vcgxO4kBRjthxZJW+112qYBiojJzoIC97EBRejYo atq5pWFsaciHWCBhB1RxEA4BavpUP9+qXWd7O4lEwZVoxfibINDK2MeLiyUjtqVc7E fLWdKl7VOdcy+Kqttu4D9dRk18Ao/BEudcYZ5VSmDU1lDLZa7gYy1z60NS36lfEjD5 ZUhzeyN7qFn6g== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LIrYb5rq50j3 for ; Fri, 20 Nov 2020 12:50:34 -0500 (EST) Received: from [172.16.0.90] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 3942C2F9331 for ; Fri, 20 Nov 2020 12:50:34 -0500 (EST) To: linux-trace-devel@vger.kernel.org From: Philippe Duplessis-Guindon Subject: Duplicate fields in event format of `regcache_sync ` Message-ID: <53fe53a9-0589-2bc6-1883-6f696fdee9ac@efficios.com> Date: Fri, 20 Nov 2020 12:50:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Hi, I am doing an ftrace plugin for Babeltrace 2 [1], and while I was parsing the event fields I had an error saying that `regcache_sync` has 2 fields named `type`. The problem seems to come from the drivers/base/regmap/trace.h file [2]. This is the patch where this was added: [3]. The `int field` type is not assigned, so I was wondering if it is normal that the field is there. This is the format of this event: $ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format name: regcache_sync ID: 1216 format: field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1;signed:0; field:int common_pid; offset:4; size:4; signed:1; field:__data_loc char[] name; offset:8; size:4; signed:1; field:__data_loc char[] status; offset:12; size:4; signed:1; field:__data_loc char[] type; offset:16; size:4; signed:1; field:int type; offset:20; size:4; signed:1; print fmt: "%s type=%s status=%s", __get_str(name), __get_str(type), __get_str(status) Thank you, Philippe [1] https://babeltrace.org/ [2] https://github.com/torvalds/linux/blob/master/drivers/base/regmap/trace.h#L129 [3] https://github.com/torvalds/linux/commit/593600890110c02eb471cf844649dee213870416