From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05754C2BB1D for ; Wed, 15 Apr 2020 01:59:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAAB8206D9 for ; Wed, 15 Apr 2020 01:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392776AbgDOB7w (ORCPT ); Tue, 14 Apr 2020 21:59:52 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:44380 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387766AbgDOB7u (ORCPT ); Tue, 14 Apr 2020 21:59:50 -0400 X-IronPort-AV: E=Sophos;i="5.72,385,1580745600"; d="scan'208";a="89044412" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 15 Apr 2020 09:59:47 +0800 Received: from G08CNEXMBPEKD06.g08.fujitsu.local (unknown [10.167.33.206]) by cn.fujitsu.com (Postfix) with ESMTP id 8F9FC406AB15; Wed, 15 Apr 2020 09:49:13 +0800 (CST) Received: from [10.167.220.69] (10.167.220.69) by G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 15 Apr 2020 09:59:42 +0800 Message-ID: <5E966A8C.2010000@cn.fujitsu.com> Date: Wed, 15 Apr 2020 09:59:40 +0800 From: Xiao Yang User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Steven Rostedt CC: Markus Elfring , , , , Ingo Molnar , Xiao Yang Subject: Re: [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation References: <5E966604.1020400@cn.fujitsu.com> <20200414214643.2e14ac76@oasis.local.home> In-Reply-To: <20200414214643.2e14ac76@oasis.local.home> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.167.220.69] X-ClientProxiedBy: G08CNEXCHPEKD05.g08.fujitsu.local (10.167.33.203) To G08CNEXMBPEKD06.g08.fujitsu.local (10.167.33.206) X-yoursite-MailScanner-ID: 8F9FC406AB15.ACA0F X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On 2020/4/15 9:46, Steven Rostedt wrote: > On Wed, 15 Apr 2020 09:40:20 +0800 > Xiao Yang wrote: > >> On 2020/4/14 15:54, Markus Elfring wrote: >>>> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger() >>> >>> I suggest to improve the change description. >>> >>> * Adjustment: >>> … operation (i. e. … >> Hi Markus, >> >> Which part of description do you want to change or could you provide an >> example for reference? > > That part is fine for me. > >> >>> >>> * Will the tag “Fixes” become relevant? >> >> Do you mean to add the following "Fixes" tag? >> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command" >> > > Yeah, that fixes tag is appropriate. But I usually add those myself, you > don't need to resend. Hi Steven, Thanks for your quick reply. Got it and I will keep the v2 patch. Thanks, Xiao Yang > > -- Steve > > > . >