Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Yordan Karadzhov <ykaradzhov@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-trace-devel@vger.kernel.org"  <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] kernel-shark-qt: Fix bug in plugin actions execution
Date: Fri, 15 Mar 2019 06:20:08 +0000
Message-ID: <6b2a660a-8e48-805f-851e-8593189e00dc@vmware.com> (raw)
In-Reply-To: <20190314200539.7bfd90e2@gandalf.local.home>



On 15.03.19 г. 2:05 ч., Steven Rostedt wrote:
> On Thu, 14 Mar 2019 20:01:14 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> Ping?
> 
> Actually this is marked as superseded in patchwork. Is it?
> 

I think this one was been pushed

https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=fbba6a95533db0d42e6e9a9241fda3616b8f03a0

Thanks!
Yordan


> -- Steve
> 
>>
>> On Wed, 9 Jan 2019 11:52:53 -0500
>> Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>>> On Wed,  9 Jan 2019 15:09:45 +0200
>>> Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>>>    
>>>> Plugin-provided actions are executed when loading the data. These
>>>> actions can be used to modify the contain of the kshark_entries
>>>
>>> "modify the contain of" ?
>>>    
>>>> generated by a given event type and we consider the case of having
>>>> more than one plugin-provided actions per event type. However, the code
>>>
>>>   "more than one plugin-provided actions per event type." also doesn't
>>>   make sense.
>>>    
>>>> that handles the case of multiple actions per-event has a bug. The "if"
>>>> was introduced with the idea that only the last per-event action will
>>>> modify the KS_PLUGIN_UNTOUCHED flag of the entry, but it misbehaves in
>>>> the case of a single per-event action in the list, followed by actions
>>>> for other events.
>>>
>>> Patch looks fine, but can you resend with a cleaner change log?
>>>
>>> Thanks!
>>>
>>> -- Steve
>>>    
>>>>
>>>> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
>>>> ---
>>>>   kernel-shark-qt/src/libkshark.c | 3 +--
>>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/kernel-shark-qt/src/libkshark.c b/kernel-shark-qt/src/libkshark.c
>>>> index 598ea52..9ab2d57 100644
>>>> --- a/kernel-shark-qt/src/libkshark.c
>>>> +++ b/kernel-shark-qt/src/libkshark.c
>>>> @@ -750,8 +750,7 @@ static size_t get_records(struct kshark_context *kshark_ctx,
>>>>   										entry->event_id))) {
>>>>   					evt_handler->event_func(kshark_ctx, rec, entry);
>>>>   					evt_handler = evt_handler->next;
>>>> -					if (!evt_handler)
>>>> -						entry->visible &= ~KS_PLUGIN_UNTOUCHED_MASK;
>>>> +					entry->visible &= ~KS_PLUGIN_UNTOUCHED_MASK;
>>>>   				}
>>>>   
>>>>   				pid = entry->pid;
>>>    
> 

      reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 13:09 [PATCH v2 0/6] Modifications toward KS 1.0 Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 1/6] kernel-shark-qt: Rearrange the "Filter" top menu Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 2/6] kernel-shark-qt: Cosmetic modifications in KsQuickContextMenu Yordan Karadzhov
2019-01-09 16:33   ` Steven Rostedt
2019-01-09 16:38     ` Yordan Karadzhov
2019-01-09 16:47       ` Steven Rostedt
2019-01-09 13:09 ` [PATCH v2 3/6] kernel-shark-qt: Make the selection in the Table less touchy Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 4/6] kernel-shark-qt: Do not auto-scrolling when the marker switches Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 5/6] kernel-shark-qt: Add the CPU filters to the filter clearing method Yordan Karadzhov
2019-01-09 13:09 ` [PATCH v2 6/6] kernel-shark-qt: Fix bug in plugin actions execution Yordan Karadzhov
2019-01-09 16:52   ` Steven Rostedt
2019-03-15  0:01     ` Steven Rostedt
2019-03-15  0:05       ` Steven Rostedt
2019-03-15  6:20         ` Yordan Karadzhov [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b2a660a-8e48-805f-851e-8593189e00dc@vmware.com \
    --to=ykaradzhov@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org linux-trace-devel@archiver.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox