Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Zamir SUN <sztsian@gmail.com>
To: tz.stoyanov@gmail.com, rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org, sztsian@gmail.com
Subject: Re: [PATCH] Documentation: Fix include level of Makefile scripts
Date: Thu, 8 Oct 2020 15:30:08 +0800
Message-ID: <7897620c-3039-5e4f-09d9-41606673fa63@gmail.com> (raw)
In-Reply-To: <20201008071858.96786-1-sztsian@gmail.com>

Note, this patch is for libtraceevent.

And I think it makes more sense to port the missing 
scripts/utilities.mak by the maintainer rather than sending a patchset 
with lots of historical commits from kernel, so I did not include that 
part here.

HTH.

On 10/8/20 3:18 PM, sztsian@gmail.com wrote:
> From: "Ziqian SUN (Zamir)" <sztsian@gmail.com>
> 
> Compiling the docs with `make doc` will result in
> 
> Makefile:2: ../../../scripts/utilities.mak: No such file or directory
> 
> This is caused by:
> * The reference should be two level up, rather than three
> * The utilities.mak is missing when fork the library out
> 
> This patch fixes the first issue by adjusting the include level. And I
> think the porting of utilities.mak is better to be done separately.
> 
> Signed-off-by: Ziqian SUN (Zamir) <sztsian@gmail.com>
> ---
>   Documentation/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index aa72ab9..edb8623 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -1,5 +1,5 @@
> -include ../../../scripts/Makefile.include
> -include ../../../scripts/utilities.mak
> +include ../scripts/Makefile.include
> +include ../scripts/utilities.mak
>   
>   # This Makefile and manpage XSL files were taken from tools/perf/Documentation
>   # and modified for libtraceevent.
> 

-- 
Zamir SUN
Fedora user
GPG : 1D86 6D4A 49CE 4BBD 72CF FCF5 D856 6E11 F2A0 525E

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08  7:18 sztsian
2020-10-08  7:30 ` Zamir SUN [this message]
2020-10-09 14:54   ` Steven Rostedt
2020-10-12 12:30     ` Zamir SUN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7897620c-3039-5e4f-09d9-41606673fa63@gmail.com \
    --to=sztsian@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git