From: Yordan Karadzhov <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] libtracefs: Add new constructors for histograms
Date: Fri, 24 Sep 2021 19:53:19 +0300 [thread overview]
Message-ID: <7c407fb1-c0e1-3c0b-46f9-9ecc40180611@gmail.com> (raw)
In-Reply-To: <20210924115434.1b2c398e@gandalf.local.home>
On 24.09.21 г. 18:54, Steven Rostedt wrote:
> On Fri, 24 Sep 2021 18:51:38 +0300
> Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
>
>>> struct tracefs_hist *
>>> tracefs_hist_alloc(struct tep_handle *tep,
>>
>> For consistency with the newly added "alloc" APIs, this should be
>> renamed. The dimensions of the histogram are part of the name, this
>> one is for N dimensions:
>> tracefs_hist_alloc_1d()
>> tracefs_hist_alloc_2d()
>> tracefs_hist_alloc_nd()
>> or something like that.
>
> I rather not have the _nd().
>
> tracefs_hist_alloc_1d()
> tracefs_hist_alloc_2d() are more just helper handlers for specific cases.
>
> tracefs_hist_alloc() should be the "main" function, and hence doesn't need
> any extra annotation.
>
My idea was the same.
Thanks!
Yordan
> -- Steve
>
next prev parent reply other threads:[~2021-09-24 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:56 [PATCH v2 0/4] Modifications of some 'hist' APIs Yordan Karadzhov (VMware)
2021-09-24 9:56 ` [PATCH v2 1/4] libtracefs: Add new constructors for histograms Yordan Karadzhov (VMware)
2021-09-24 15:51 ` Tzvetomir Stoyanov
2021-09-24 15:54 ` Steven Rostedt
2021-09-24 16:53 ` Yordan Karadzhov [this message]
2021-09-24 9:57 ` [PATCH v2 2/4] libtracefs: Transform tracefs_hist_add_sort_key() Yordan Karadzhov (VMware)
2021-09-24 15:51 ` Tzvetomir Stoyanov
2021-09-24 16:56 ` Yordan Karadzhov
2021-11-10 22:43 ` Steven Rostedt
2021-09-24 9:57 ` [PATCH v2 3/4] libtracefs: Add new 'hist' APIs Yordan Karadzhov (VMware)
2021-09-24 9:57 ` [PATCH v2 4/4] libtracefs: Update 'hist' documentation Yordan Karadzhov (VMware)
2021-10-11 13:55 ` [RFC] Modifications of some 'hist' APIs Yordan Karadzhov
2021-10-13 2:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c407fb1-c0e1-3c0b-46f9-9ecc40180611@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).